Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044154
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advance Warehouse Operationsminorhave not tried2020-05-22 11:452020-06-03 17:45
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision522819bdd3af
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044154: Apply new HQL Style in CheckScheduledBackgroundProcesses.java

DescriptionCheckScheduledBackgroundProcesses.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120618)
hgbot (developer)
2020-06-03 17:45

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 522819bdd3af48deab803496b038b371120dc55a
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 11:58:53 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/522819bdd3af48deab803496b038b371120dc55a [^]

fixes BUG-44154:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckScheduledBackgroundProcesses.java
---
(0120619)
hgbot (developer)
2020-06-03 17:45

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 78f1db9c3ca8c81797079f6127daa791060147a7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 17:45:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/78f1db9c3ca8c81797079f6127daa791060147a7 [^]

Related to ISSUE-44154. Format changes to improve redability and remove
unnecessary toString() call

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckScheduledBackgroundProcesses.java
---
(0120620)
dmiguelez (developer)
2020-06-03 17:45

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-22 11:45 inigo_lerga New Issue
2020-05-22 11:45 inigo_lerga Assigned To => inigo_lerga
2020-05-22 11:45 inigo_lerga Relationship added related to 0041287
2020-05-22 11:45 inigo_lerga Status new => scheduled
2020-06-03 17:45 hgbot Checkin
2020-06-03 17:45 hgbot Note Added: 0120618
2020-06-03 17:45 hgbot Status scheduled => resolved
2020-06-03 17:45 hgbot Resolution open => fixed
2020-06-03 17:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/522819bdd3af48deab803496b038b371120dc55a [^]
2020-06-03 17:45 hgbot Checkin
2020-06-03 17:45 hgbot Note Added: 0120619
2020-06-03 17:45 dmiguelez Review Assigned To => dmiguelez
2020-06-03 17:45 dmiguelez Note Added: 0120620
2020-06-03 17:45 dmiguelez Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker