Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044153
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advance Warehouse Operationsminorhave not tried2020-05-22 11:302020-06-03 17:34
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision16d322d56872
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044153: Apply new HQL Style in CheckProductAUMAreMultiples.java

DescriptionCheckProductAUMAreMultiples.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120169)
inigo_lerga (developer)
2020-05-22 11:43

--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120614)
hgbot (developer)
2020-06-03 17:33

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 16d322d56872061f85d76a9d17ba10c8a25a8e33
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 11:47:45 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/16d322d56872061f85d76a9d17ba10c8a25a8e33 [^]

fixes BUG-44153:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckProductAUMAreMultiples.java
---
(0120615)
hgbot (developer)
2020-06-03 17:33

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 4c4004d3d49729c04acba1b082280abb0d27259a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 17:33:36 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/4c4004d3d49729c04acba1b082280abb0d27259a [^]

Related to ISSUE-44153. Removed unnecessary toString() call

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckProductAUMAreMultiples.java
---
(0120616)
dmiguelez (developer)
2020-06-03 17:34

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-22 11:30 inigo_lerga New Issue
2020-05-22 11:30 inigo_lerga Assigned To => inigo_lerga
2020-05-22 11:32 inigo_lerga Relationship added related to 0041287
2020-05-22 11:32 inigo_lerga Status new => scheduled
2020-05-22 11:43 inigo_lerga Note Added: 0120169
2020-06-03 17:33 hgbot Checkin
2020-06-03 17:33 hgbot Note Added: 0120614
2020-06-03 17:33 hgbot Status scheduled => resolved
2020-06-03 17:33 hgbot Resolution open => fixed
2020-06-03 17:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/16d322d56872061f85d76a9d17ba10c8a25a8e33 [^]
2020-06-03 17:33 hgbot Checkin
2020-06-03 17:33 hgbot Note Added: 0120615
2020-06-03 17:34 dmiguelez Review Assigned To => dmiguelez
2020-06-03 17:34 dmiguelez Note Added: 0120616
2020-06-03 17:34 dmiguelez Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker