Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044149
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advance Warehouse Operationsminorhave not tried2020-05-22 09:372020-06-03 16:51
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision9a888c14243c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044149: Apply new HQL Style in CheckIRAWithoutRouting.java

DescriptionCheckIRAWithoutRouting.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120158)
inigo_lerga (developer)
2020-05-22 10:02

--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120605)
hgbot (developer)
2020-06-03 16:51

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 9a888c14243ca21ed675309c425e4c33cd0b1671
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 10:01:30 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9a888c14243ca21ed675309c425e4c33cd0b1671 [^]

fixes BUG-44149:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckIRAWithoutRouting.java
---
(0120606)
hgbot (developer)
2020-06-03 16:51

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 26cf583da581cacd0ba4e23123c60ca20112415a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 16:50:59 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/26cf583da581cacd0ba4e23123c60ca20112415a [^]

Related to ISSUE-44149: Fixes wrong formatter tag and makes changes
to format to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckIRAWithoutRouting.java
---
(0120607)
dmiguelez (developer)
2020-06-03 16:51

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-22 09:37 inigo_lerga New Issue
2020-05-22 09:37 inigo_lerga Assigned To => inigo_lerga
2020-05-22 09:37 inigo_lerga Relationship added related to 0041287
2020-05-22 09:37 inigo_lerga Status new => scheduled
2020-05-22 10:02 inigo_lerga Note Added: 0120158
2020-06-03 16:51 hgbot Checkin
2020-06-03 16:51 hgbot Note Added: 0120605
2020-06-03 16:51 hgbot Status scheduled => resolved
2020-06-03 16:51 hgbot Resolution open => fixed
2020-06-03 16:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9a888c14243ca21ed675309c425e4c33cd0b1671 [^]
2020-06-03 16:51 hgbot Checkin
2020-06-03 16:51 hgbot Note Added: 0120606
2020-06-03 16:51 dmiguelez Review Assigned To => dmiguelez
2020-06-03 16:51 dmiguelez Note Added: 0120607
2020-06-03 16:51 dmiguelez Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker