Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044122
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-20 15:072020-06-03 12:23
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision9423b14ba203
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0044122: Apply new HQL Style in PK_QueryBuilder.java

DescriptionPK_QueryBuilder.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120582)
hgbot (developer)
2020-06-03 12:23

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 9423b14ba203829fb533244e3e488de00768e83f
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 20 16:20:06 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9423b14ba203829fb533244e3e488de00768e83f [^]

fixes BUG-44122:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehousealgorithm/PK_QueryBuilder.java
---
(0120583)
hgbot (developer)
2020-06-03 12:23

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 5ad0dbf680c4ee69305fe0a290c02b88bde13d3e
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 12:23:15 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5ad0dbf680c4ee69305fe0a290c02b88bde13d3e [^]

Related to ISSUE-44122. Removed some formatter on/off tags,
as all the sentences belong to the same query and it is easier to
read it this way.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehousealgorithm/PK_QueryBuilder.java
---
(0120584)
dmiguelez (viewer)
2020-06-03 12:23

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-20 15:07 inigo_lerga New Issue
2020-05-20 15:07 inigo_lerga Assigned To => inigo_lerga
2020-05-20 15:07 inigo_lerga OBNetwork customer => No
2020-05-20 15:07 inigo_lerga Relationship added related to 0041287
2020-05-20 15:07 inigo_lerga Status new => scheduled
2020-06-03 12:23 hgbot Checkin
2020-06-03 12:23 hgbot Note Added: 0120582
2020-06-03 12:23 hgbot Status scheduled => resolved
2020-06-03 12:23 hgbot Resolution open => fixed
2020-06-03 12:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9423b14ba203829fb533244e3e488de00768e83f [^]
2020-06-03 12:23 hgbot Checkin
2020-06-03 12:23 hgbot Note Added: 0120583
2020-06-03 12:23 dmiguelez Review Assigned To => dmiguelez
2020-06-03 12:23 dmiguelez Note Added: 0120584
2020-06-03 12:23 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker