0043851: Wrong error handling if the donwload of a ProcessUploadedFile process fails

Description

In case an error is thrown while dowloading the result of a ProcessUploadedFile, the error is not being handled properly.

Steps To Reproduce

1) Apply the attached patch which forces an error while dowloading a file with a ProcessUploadedFile
2) Go to the "Business Partner Set" window
3) Click in the "upload file" toolbar button and upload the attached file (bpSets.txt)
4) Note that after our forced error is thrown, it is not being managed properly. The following stack trace is raised in the log:
org.openbravo.base.exception.OBException: Error uploading file JSONObject["viewID"] not found.
    at org.openbravo.client.application.businesslogic.ProcessUploadedFile.post(ProcessUploadedFile.java:98) ~[classes/:?]
    at org.openbravo.client.application.businesslogic.ProcessUploadedFile.doPost(ProcessUploadedFile.java:65) ~[classes/:?]
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:661) ~[servlet-api.jar:?]
....

Proposed Solution

Note that the ProcessUploadedFile already has a mechanism to handle the error and display it in the toolbar. The problem is that the viewID is not being sent in the request to download the resulting file.

Adding the viewID in the request fixes the problem.

Tags

No tags attached.

Attached Files

bpSets.txt [^] (9 bytes) 2020-04-23 19:54 [Show Content] [Hide Content]

WVG/C0001

forcedError.diff [^] (884 bytes) 2020-04-23 19:55 [Show Content] [Hide Content]

diff --git a/modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ProcessUploadedFile.java b/modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ProcessUploadedFile.java
--- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ProcessUploadedFile.java
+++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ProcessUploadedFile.java
@@ -82,6 +82,9 @@
       if ("upload".equals(paramValues.getString("command"))) {
         uploadFile(vars, request, response, paramValues);
       } else if ("download".equals(paramValues.getString("command"))) {
+        if (true) {
+          throw new OBException("error!");
+        }
         readAndReturnResult(response, paramValues);
       } else {
         pageError(response);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2020-04-23 19:54	caristu	New Issue
2020-04-23 19:54	caristu	Assigned To	=> platform
2020-04-23 19:54	caristu	File Added: bpSets.txt
2020-04-23 19:54	caristu	Modules	=> Core
2020-04-23 19:54	caristu	Triggers an Emergency Pack	=> No
2020-04-23 19:55	caristu	File Added: forcedError.diff
2022-02-01 07:24	alostale	Assigned To	platform => Triage Platform Base