Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0043803 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] 04. Warehouse management | minor | have not tried | 2020-04-20 13:48 | 2020-04-27 14:06 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | inigo_lerga | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR20Q1.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 19e0f1b700f6 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR20Q1.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | vmromanos | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0043803: Referencedinventory tests are incompatible with AWO and should auto-skip themselves if AWO is present | |||||||
| Description | The referencesinventory junit tests in PI are not compatible with AWO module as they create some data not compliant with some new constraint added when installing AWO. To avoid them failing when AWO is present they can be disabled manually however that needs to be done in every environment (developer or many CI jobs) having AWO installed. Current list: org.openbravo.test.referencedinventory.ReferencedInventoryBoxForcedReservation org.openbravo.test.referencedinventory.ReferencedInventoryBoxFullReservationTest org.openbravo.test.referencedinventory.ReferencedInventoryBoxOverReservation1MovementLineTest org.openbravo.test.referencedinventory.ReferencedInventoryBoxOverReservation2MovementLinesTest org.openbravo.test.referencedinventory.ReferencedInventoryBoxPartialReservation1MovementLineTest org.openbravo.test.referencedinventory.ReferencedInventoryBoxPartialReservation2MovementLinesTest org.openbravo.test.referencedinventory.ReferencedInventoryBoxSeveralStorageDetailsTest org.openbravo.test.referencedinventory.ReferencedInventoryBoxTest org.openbravo.test.referencedinventory.ReferencedInventoryExceptionTest org.openbravo.test.referencedinventory.ReferencedInventoryFullBoxTest org.openbravo.test.referencedinventory.ReferencedInventoryFullUnboxFullReservation org.openbravo.test.referencedinventory.ReferencedInventoryFullUnboxPartialReservation org.openbravo.test.referencedinventory.ReferencedInventoryFullUnboxTest org.openbravo.test.referencedinventory.ReferencedInventoryPartialBoxTest org.openbravo.test.referencedinventory.ReferencedInventoryPartialUnboxFullReservation org.openbravo.test.referencedinventory.ReferencedInventoryPartialUnboxPartialReservation1MovementLineUnboxTest org.openbravo.test.referencedinventory.ReferencedInventoryPartialUnboxPartialReservation2MovementLinesUnboxTest org.openbravo.test.referencedinventory.ReferencedInventoryPartialUnboxTest org.openbravo.test.referencedinventory.ReferencedInventorySequenceTest org.openbravo.test.referencedinventory.ReferencedInventoryTest org.openbravo.test.referencedinventory.ReferencedInventoryTestSuite org.openbravo.test.referencedinventory.ReferencedInventoryTestUtils org.openbravo.test.referencedinventory.ReferencedInventoryUnboxReservationTest org.openbravo.test.referencedinventory.ReferencedInventoryUnboxTest Instead those tests should check 'awo is present' and auto-skip themselves do avoid needing to have replicate that long exception list everywhere. Attached patch implements that by checking if 'org.openbravo.warehouse.advancedwarehouse' module is present in the workspace. | |||||||
| Steps To Reproduce | 1.) Fresh pi 2.) Add awo + dependencies https://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core [^] 3.) run ant run.all.tests Notice tests listed above failing | |||||||
| Proposed Solution | Similar to code for skipping tests with 'config/disabled-tests' add assumeThat(<awo-not-installed>) as @Before. As all referencedinventory tests have a single base class ReferencedInventoryTest that can be done centrally there easily. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0119424) hgbot (developer) 2020-04-27 13:03 |
Repository: erp/backports/3.0PR20Q1.1 Changeset: 19e0f1b700f6b613320252b1b6778a7b25313e30 Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Mon Apr 27 13:03:45 2020 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR20Q1.1/rev/19e0f1b700f6b613320252b1b6778a7b25313e30 [^] Fixed ISSUE-43803. Make referencedinventory test auto-skip if AWO is installed. Those test are not compatible with AWO as data they create does not comply with some new constraint added by AWO. So far that was required to be handled manually by adding config/disabled-tests i.e. in every CI job with AWO installed to list the all individual tests here to skip them. This issue makes that behavior automatic by checking inside a central base-class if AWO module is present and skipping the tests themselves (using similar logic as is used by code for skipping config/disabled-tests from OBBaseTest). Note that the repeated (per test) calls to isModulePresent are very fast as that function caches the data inside so no need for caching isAwoInstalled inside the test-class. --- M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java --- |
|
(0119429) vmromanos (viewer) 2020-04-27 14:05 |
Code review OK |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-04-21 10:18 | shuehner | Type | defect => backport |
| 2020-04-21 10:18 | shuehner | Target Version | => 3.0PR20Q1.1 |
| 2020-04-24 12:59 | inigo_lerga | Assigned To | Triage Finance => inigo_lerga |
| 2020-04-27 13:03 | hgbot | Checkin | |
| 2020-04-27 13:03 | hgbot | Note Added: 0119424 | |
| 2020-04-27 13:03 | hgbot | Status | scheduled => resolved |
| 2020-04-27 13:03 | hgbot | Resolution | open => fixed |
| 2020-04-27 13:03 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR20Q1.1/rev/19e0f1b700f6b613320252b1b6778a7b25313e30 [^] |
| 2020-04-27 14:05 | vmromanos | Review Assigned To | => vmromanos |
| 2020-04-27 14:05 | vmromanos | Note Added: 0119429 | |
| 2020-04-27 14:05 | vmromanos | Status | resolved => closed |
| 2020-04-27 14:06 | vmromanos | Fixed in Version | => 3.0PR20Q1.1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |