Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043784
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2020-04-20 12:442020-04-27 12:11
Reportersebastien_lironView Statuspublic 
Assigned Tocberner 
PriorityurgentResolutionfixedFixed in VersionPR20Q3
StatusclosedFix in branchFixed in SCM revision40cdc04087bf
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product Version3.0PR19Q2SCM revision 
Review Assigned Tocaristu
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043784: OBMultiSelectorItem parameter values are not saved in the form

DescriptionOBMultiSelectorItem parameter values are not saved in the form. This is because OBMultiSelectorItem extends CanvasItem and by default no value from the CanvasItem is be saved in the DynamicForm values. See[1].

This behavior causes that the selected values in the multiselector are never sent to the backend when a P&E grid is refreshed[2]. But the rest of parameter values are indeed being sent.

[1] https://www.smartclient.com/smartclient-release/isomorphic/system/reference/?id=search%3DCanvasItem [^]
[2] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js#L206 [^]
Steps To Reproduce1) Install the following module: https://gitlab.com/openbravo/demo/org.openbravo.platform.features [^]
2) Apply the attached patch (gridAndMultipleSelector.diff) on that module which provides the functionality to reproduce the issue.
3) ant smartbuild -Dlocal=no
4) Open the "Process Definition test" window
5) Select a business partner with the SingleBP parameter and note that the grid is refreshed correctly filtering by the selected business partner
6) Use the MultiBP parameter and select several business partners. Note that the grid is NOT refreshed filtering by the selected business partners.
  6A) Check the SimpleOrderHQLTransformer.java class and note that the filtering by MultiBP is not implemented because the selected values are not being received.
Proposed SolutionIn the case of multiselectors we should override the default CanvasItem behavior because the default behavior is is appropriate if the Canvas does not participate in editing a value of the form and is embedded in the form for layout or UI purposes only (e.g. ButtonItem, SectionItem).

In OBMultiSelectorItem we want to save its values in the form. See attached fix with a proposed solution to be tested in deep.
TagsNo tags attached.
Attached Filesdiff file icon proposedFix.diff [^] (1,097 bytes) 2020-04-21 12:41 [Show Content]
diff file icon gridAndMultipleSelector.diff [^] (40,782 bytes) 2020-04-23 12:21 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0026555pi closedAugustoMauch Problem in initialization of CanvasItem when a new record is created in grid mode. 
related to defect 0043849 closedcberner Multiselectors don't refresh form on change if no element is selected or if external X icon is pressed 

-  Notes
(0119415)
hgbot (developer)
2020-04-27 11:42

 Repository: erp/devel/pi
Changeset: 40cdc04087bfeec81f2ea0ad7669eee83338ece0
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Thu Apr 23 18:59:31 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/40cdc04087bfeec81f2ea0ad7669eee83338ece0 [^]

Fixes ISSUE-43784: MultiSelector parameter values are saved in form onChange

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-multi-selector-item.js
---
(0119419)
caristu (developer)
2020-04-27 12:11
edited on: 2020-04-27 12:14

 Reviewed and tested.

- See MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/66 [^]
- Tested with the "Process Definition test" that can be found here: https://gitlab.com/openbravo/demo/org.openbravo.platform.features [^]

- Issue History
Date Modified Username Field Change
2020-04-20 12:44 sebastien_liron New Issue
2020-04-20 12:44 sebastien_liron Assigned To => platform
2020-04-20 12:44 sebastien_liron File Added: productCsvExporter_After_Implemeting_MultiSelector_20200417 (1).diff
2020-04-20 12:44 sebastien_liron Web browser => Google Chrome
2020-04-20 12:44 sebastien_liron Modules => Core
2020-04-20 12:44 sebastien_liron Triggers an Emergency Pack => No
2020-04-21 06:44 alostale Web browser Google Chrome => Google Chrome
2020-04-21 06:44 alostale Priority immediate => urgent
2020-04-21 06:44 alostale Severity critical => major
2020-04-21 12:21 caristu Web browser Google Chrome => Google Chrome
2020-04-21 12:21 caristu Summary multiselector reference as non grid parameter data is not loaded in the HqlQueryTransformer transformHqlQuery parameters => multiselector parameter values are not saved in the form
2020-04-21 12:21 caristu Description Updated View Revisions
2020-04-21 12:21 caristu Steps to Reproduce Updated View Revisions
2020-04-21 12:21 caristu Proposed Solution updated
2020-04-21 12:21 caristu File Deleted: productCsvExporter_After_Implemeting_MultiSelector_20200417 (1).diff
2020-04-21 12:21 caristu Web browser Google Chrome => Google Chrome
2020-04-21 12:21 caristu Description Updated View Revisions
2020-04-21 12:21 caristu File Added: gridAndMultipleSelector.diff
2020-04-21 12:25 caristu File Added: proposedFix.diff
2020-04-21 12:26 caristu Web browser Google Chrome => Google Chrome
2020-04-21 12:26 caristu Assigned To platform => cberner
2020-04-21 12:28 caristu Relationship added related to 0026555
2020-04-21 12:29 caristu Web browser Google Chrome => Google Chrome
2020-04-21 12:29 caristu Steps to Reproduce Updated View Revisions
2020-04-21 12:33 caristu Web browser Google Chrome => Google Chrome
2020-04-21 12:33 caristu Summary multiselector parameter values are not saved in the form => OBMultiSelectorItem parameter values are not saved in the form
2020-04-21 12:33 caristu Description Updated View Revisions
2020-04-21 12:41 caristu File Deleted: proposedFix.diff
2020-04-21 12:41 caristu File Added: proposedFix.diff
2020-04-21 12:44 caristu File Deleted: gridAndMultipleSelector.diff
2020-04-21 12:44 caristu File Added: gridAndMultipleSelector.diff
2020-04-23 11:01 caristu File Deleted: gridAndMultipleSelector.diff
2020-04-23 11:01 caristu File Added: gridAndMultipleSelector.diff
2020-04-23 12:21 cberner File Deleted: gridAndMultipleSelector.diff
2020-04-23 12:21 cberner File Added: gridAndMultipleSelector.diff
2020-04-23 18:47 cberner Relationship added related to 0043849
2020-04-23 18:48 cberner Status new => scheduled
2020-04-27 11:42 hgbot Checkin
2020-04-27 11:42 hgbot Note Added: 0119415
2020-04-27 11:42 hgbot Status scheduled => resolved
2020-04-27 11:42 hgbot Resolution open => fixed
2020-04-27 11:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/40cdc04087bfeec81f2ea0ad7669eee83338ece0 [^]
2020-04-27 12:11 caristu Review Assigned To => caristu
2020-04-27 12:11 caristu Note Added: 0119419
2020-04-27 12:11 caristu Status resolved => closed
2020-04-27 12:11 caristu Fixed in Version => 3.0PR20Q3
2020-04-27 12:14 caristu Note Edited: 0119419 View Revisions

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker