Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043668
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] OMSminoralways2020-04-06 09:242020-05-19 16:36
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisione84f66129b5d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Regression introduced in release
Summary

0043668: Ticket definition in Swagger does not fit POJOs definition

DescriptionThe problem resides in the Swagger ticket definition, as it does not fit POJOs definition. Therefore, the infrastructure in java does not know how to fill the warehouses' information. The current definition is as follows:

    "includedWarehouses": [
      {
        "warehouse": {
          "id": "B2D40D8A5D644DD89E329DC297309055",
          "_identifier": "España Región Norte"
        }
      }
    ],
    "excludedWarehouses": [
      {
        "warehouse": {
          "id": "5848641D712545C7AE0FE9634A163648",
          "_identifier": "España Región Sur"
        }
      }
    ]
  
In other words, each warehouse list's object has a 'warehouse' property that does not exist in the java's definition of the ticket. Moreover, the Warehouse java definition does not have a 'warehouse' property either.
Steps To Reproduce-
Proposed SolutionTo stick to the current definition, the info should be articulated with the following structure:

    "includedWarehouses": [
      {
          "id": "B2D40D8A5D644DD89E329DC297309055",
          "_identifier": "España Región Norte",
          "searchKey": "RN"
      }
    ],
    "excludedWarehouses": [
      {
          "id": "5848641D712545C7AE0FE9634A163648",
          "_identifier": "España Región Sur",
          "searchKey": "RS"
      }
    ]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0119030)
inigo_lerga (reporter)
2020-04-07 10:58
edited on: 2020-04-24 12:12

--Test Plan Mantis--
Beforehand, the environment needs to have the api generated
and an OMS configuration setup.
  - Enter the OMS Web Service API
  - Select oms1.1.0
  - Press the Authorize button and Log in with
    Openbravo - openbravo as usual.
  - Open the OMS Web Service POST section (the green one)
  - Press the Try it out button
  - Select the "Ticket with several lines identified by id and/or searchKey,
    including and excluding warehouses" in the Examples selector
  - Execute the example

#In this moment the modified ticket is executed#

To see the result of the execution of the ticket:
  - In the Backend, go to the OMS Run window.
  - Open the record corresponding to the most recent execution and observe the
    included and excluded warehouses are correctly displayed in the Included
    and Excluded Tabs. The Status of the Header shows the result of execution
    of the ticket.

(0120055)
hgbot (developer)
2020-05-19 16:34

Repository: erp/pmods/org.openbravo.oms
Changeset: e84f66129b5d4d18754a6e2df9039dfe9f9b9bb1
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri Apr 24 12:29:50 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.oms/rev/e84f66129b5d4d18754a6e2df9039dfe9f9b9bb1 [^]

fixes BUG-43668:Corrected Ticket definition in Swagger

---
M api/org.openbravo.oms-oms1.1.0.yml
---
(0120058)
vmromanos (manager)
2020-05-19 16:36

Code review + testing OK

- Issue History
Date Modified Username Field Change
2020-04-06 09:24 inigo_lerga New Issue
2020-04-06 09:24 inigo_lerga Assigned To => inigo_lerga
2020-04-06 14:02 inigo_lerga Status new => scheduled
2020-04-07 10:58 inigo_lerga Note Added: 0119030
2020-04-24 12:12 inigo_lerga Note Edited: 0119030 View Revisions
2020-04-24 12:12 inigo_lerga Note Edited: 0119030 View Revisions
2020-05-19 16:34 hgbot Checkin
2020-05-19 16:34 hgbot Note Added: 0120055
2020-05-19 16:34 hgbot Status scheduled => resolved
2020-05-19 16:34 hgbot Resolution open => fixed
2020-05-19 16:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.oms/rev/e84f66129b5d4d18754a6e2df9039dfe9f9b9bb1 [^]
2020-05-19 16:36 vmromanos Review Assigned To => vmromanos
2020-05-19 16:36 vmromanos Note Added: 0120058
2020-05-19 16:36 vmromanos Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker