Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043580
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2020-03-25 18:012020-03-26 14:12
ReportershuehnerView Statuspublic 
Assigned Toguilleaer 
PrioritynormalResolutionfixedFixed in VersionRR20Q2
StatusclosedFix in branchFixed in SCM revision535da87eeb82
ProjectionnoneETAnoneTarget VersionRR20Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043580: Apply new HQL style in CrossStoreInfoProperties

Description1. Avoid use of StringBuilder use normal Strings.
2. HQL formatting is important for improving readability.
3. Avoid use of Property Constant if any

In this specific file this is about the 'address' StringBuilder() which ends up as executable HQL via HQLProperty

Apart of removing the StringBuilder reformatting the HQL text should improve readability quite a bit
Steps To Reproduce-
TagsNo tags attached.
Attached Filesdiff file icon diffIssue43580.diff [^] (1,954 bytes) 2020-03-25 18:24 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0118829)
hgbot (developer)
2020-03-26 09:18

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 535da87eeb8211f17852cec1589d2ed49019f2c3
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Mar 26 09:18:28 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/535da87eeb8211f17852cec1589d2ed49019f2c3 [^]

fixed BUG 43580: Change StringBuilder to String and format query

---
M src/org/openbravo/retail/posterminal/master/CrossStoreInfoProperties.java
---

- Issue History
Date Modified Username Field Change
2020-03-25 18:01 shuehner New Issue
2020-03-25 18:01 shuehner Assigned To => Retail
2020-03-25 18:01 shuehner Triggers an Emergency Pack => No
2020-03-25 18:01 shuehner Relationship added related to 0041287
2020-03-25 18:02 shuehner Target Version => RR20Q2
2020-03-25 18:24 guilleaer File Added: diffIssue43580.diff
2020-03-26 09:18 hgbot Checkin
2020-03-26 09:18 hgbot Note Added: 0118829
2020-03-26 09:18 hgbot Status new => resolved
2020-03-26 09:18 hgbot Resolution open => fixed
2020-03-26 09:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/535da87eeb8211f17852cec1589d2ed49019f2c3 [^]
2020-03-26 09:58 marvintm Assigned To Retail => guilleaer
2020-03-26 14:12 marvintm Review Assigned To => marvintm
2020-03-26 14:12 marvintm Status resolved => closed
2020-03-26 14:12 marvintm Fixed in Version => RR20Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker