0043572: When fixing HQLStyle issues in posterminal 4 cases we not fully fixed

Description

This is follow up to issue 41890 which did not fully fix 4 cases inside posterminal.

While it rewrote creation of HQL from StringBuilder to String it missed to remove the old .toString() call added when using the StringBuilder.

As calling toString() on a String is not useful that should be removed.
Also not having that fixed triggers still false positives with our automation.

Steps To Reproduce

Tags

No tags attached.

Attached Files

43572.diff [^] (3,050 bytes) 2020-03-25 13:53 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/UpdateProductCategoryByAssortmentBackground.java b/src/org/openbravo/retail/posterminal/UpdateProductCategoryByAssortmentBackground.java
--- a/src/org/openbravo/retail/posterminal/UpdateProductCategoryByAssortmentBackground.java
+++ b/src/org/openbravo/retail/posterminal/UpdateProductCategoryByAssortmentBackground.java
@@ -75,7 +75,7 @@
             + "where obpl.id= :assortmentid and mp.active='Y'";
 
         final Session session = OBDal.getInstance().getSession();
-        final Query<String> query = session.createQuery(hql.toString(), String.class);
+        final Query<String> query = session.createQuery(hql, String.class);
         query.setParameter("assortmentid", assortment.getId());
         ScrollableResults scroll = query.scroll(ScrollMode.SCROLL_SENSITIVE);
         try {
diff --git a/src/org/openbravo/retail/posterminal/process/CheckUpdated.java b/src/org/openbravo/retail/posterminal/process/CheckUpdated.java
--- a/src/org/openbravo/retail/posterminal/process/CheckUpdated.java
+++ b/src/org/openbravo/retail/posterminal/process/CheckUpdated.java
@@ -67,8 +67,7 @@
         + "WHERE importStatus = 'Initial' " //
         + "AND (typeofdata = 'Order' OR typeofdata = 'OBPOS_CancelLayaway' OR typeofdata = 'OBPOS_VoidLayaway') " //
         + "AND jsonInfo LIKE :orderId";
-    final Query<String> importEntryQuery = session.createQuery(importEntryHQL.toString(),
-        String.class);
+    final Query<String> importEntryQuery = session.createQuery(importEntryHQL, String.class);
     importEntryQuery.setParameter("orderId", whereClause);
     importEntryQuery.setMaxResults(1);
     return importEntryQuery.uniqueResult() != null;
@@ -82,8 +81,8 @@
         + "WHERE orderstatus = 'N' " //
         + "AND (typeofdata = 'Order' OR typeofdata = 'OBPOS_CancelLayaway' OR typeofdata = 'OBPOS_VoidLayaway') " //
         + "AND jsonInfo LIKE :orderId";
-    final Query<String> errorWhileImportingQuery = session
-        .createQuery(errorWhileImportingHQL.toString(), String.class);
+    final Query<String> errorWhileImportingQuery = session.createQuery(errorWhileImportingHQL,
+        String.class);
     errorWhileImportingQuery.setParameter("orderId", whereClause);
     errorWhileImportingQuery.setMaxResults(1);
     return errorWhileImportingQuery.uniqueResult() != null;
diff --git a/src/org/openbravo/retail/posterminal/stock/StoreDetailedStock.java b/src/org/openbravo/retail/posterminal/stock/StoreDetailedStock.java
--- a/src/org/openbravo/retail/posterminal/stock/StoreDetailedStock.java
+++ b/src/org/openbravo/retail/posterminal/stock/StoreDetailedStock.java
@@ -57,7 +57,7 @@
       hqlQuery += " order by wh.name";
 
       final Session session = OBDal.getInstance().getSession();
-      final Query<Object[]> query = session.createQuery(hqlQuery.toString(), Object[].class);
+      final Query<Object[]> query = session.createQuery(hqlQuery, Object[].class);
       query.setParameter("orgId", orgId);
       query.setParameter("prodId", prodId);

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0041890		closed	alekosmp86	Retail Modules	StringBuffer/Builder in Retail modules should be replaced by String
related to	design defect	0041287		acknowledged	Triage Platform Base	Openbravo ERP	Tracking issue: Convert HQL to apply new style

Notes
(0118828) hgbot (developer) 2020-03-26 09:18	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 3de126a19f4c716922e3db91ba0964906f9620be Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Wed Mar 25 14:06:40 2020 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3de126a19f4c716922e3db91ba0964906f9620be [^] fixed BUG 43572: Change StringBuilder to String in some HQL --- M src/org/openbravo/retail/posterminal/UpdateProductCategoryByAssortmentBackground.java M src/org/openbravo/retail/posterminal/process/CheckUpdated.java M src/org/openbravo/retail/posterminal/stock/StoreDetailedStock.java ---

Issue History
Date Modified	Username	Field	Change
2020-03-25 13:51	shuehner	New Issue
2020-03-25 13:51	shuehner	Assigned To	=> Retail
2020-03-25 13:51	shuehner	Triggers an Emergency Pack	=> No
2020-03-25 13:51	shuehner	Relationship added	related to 0041890
2020-03-25 13:51	shuehner	Target Version	=> RR20Q2
2020-03-25 13:53	shuehner	File Added: 43572.diff
2020-03-25 13:54	shuehner	Relationship added	related to 0041287
2020-03-26 09:18	hgbot	Checkin
2020-03-26 09:18	hgbot	Note Added: 0118828
2020-03-26 09:18	hgbot	Status	new => resolved
2020-03-26 09:18	hgbot	Resolution	open => fixed
2020-03-26 09:18	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3de126a19f4c716922e3db91ba0964906f9620be [^]
2020-03-26 09:58	marvintm	Assigned To	Retail => guilleaer
2020-03-26 14:11	marvintm	Review Assigned To	=> marvintm
2020-03-26 14:11	marvintm	Status	resolved => closed
2020-03-26 14:11	marvintm	Fixed in Version	=> RR20Q2