Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043572
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2020-03-25 13:512020-03-26 14:11
ReportershuehnerView Statuspublic 
Assigned Toguilleaer 
PrioritynormalResolutionfixedFixed in VersionRR20Q2
StatusclosedFix in branchFixed in SCM revision3de126a19f4c
ProjectionnoneETAnoneTarget VersionRR20Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043572: When fixing HQLStyle issues in posterminal 4 cases we not fully fixed

DescriptionThis is follow up to issue 41890 which did not fully fix 4 cases inside posterminal.

While it rewrote creation of HQL from StringBuilder to String it missed to remove the old .toString() call added when using the StringBuilder.

As calling toString() on a String is not useful that should be removed.
Also not having that fixed triggers still false positives with our automation.
Steps To Reproduce-
TagsNo tags attached.
Attached Filesdiff file icon 43572.diff [^] (3,050 bytes) 2020-03-25 13:53 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0041890 closedalekosmp86 Retail Modules StringBuffer/Builder in Retail modules should be replaced by String 
related to design defect 0041287 acknowledgedplatform Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0118828)
hgbot (developer)
2020-03-26 09:18

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3de126a19f4c716922e3db91ba0964906f9620be
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Mar 25 14:06:40 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3de126a19f4c716922e3db91ba0964906f9620be [^]

fixed BUG 43572: Change StringBuilder to String in some HQL

---
M src/org/openbravo/retail/posterminal/UpdateProductCategoryByAssortmentBackground.java
M src/org/openbravo/retail/posterminal/process/CheckUpdated.java
M src/org/openbravo/retail/posterminal/stock/StoreDetailedStock.java
---

- Issue History
Date Modified Username Field Change
2020-03-25 13:51 shuehner New Issue
2020-03-25 13:51 shuehner Assigned To => Retail
2020-03-25 13:51 shuehner Triggers an Emergency Pack => No
2020-03-25 13:51 shuehner Relationship added related to 0041890
2020-03-25 13:51 shuehner Target Version => RR20Q2
2020-03-25 13:53 shuehner File Added: 43572.diff
2020-03-25 13:54 shuehner Relationship added related to 0041287
2020-03-26 09:18 hgbot Checkin
2020-03-26 09:18 hgbot Note Added: 0118828
2020-03-26 09:18 hgbot Status new => resolved
2020-03-26 09:18 hgbot Resolution open => fixed
2020-03-26 09:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3de126a19f4c716922e3db91ba0964906f9620be [^]
2020-03-26 09:58 marvintm Assigned To Retail => guilleaer
2020-03-26 14:11 marvintm Review Assigned To => marvintm
2020-03-26 14:11 marvintm Status resolved => closed
2020-03-26 14:11 marvintm Fixed in Version => RR20Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker