Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043475
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2020-03-11 09:122020-05-25 08:16
ReporterkchoperenaView Statuspublic 
Assigned Toprakashmurugesan88 
PriorityhighResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revisiond7d937428753
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043475: Any component that extends OB.UI.Modal and have maxheight defined without bodyParent, fails in WebPOS login

DescriptionThe OB.UI.Modal does not have a bodyParent defined. In the initComponents function, there is a code to set the maxheight to the bodyParent but there is no bodyParent present in OB.UI.Modal.

if (this.maxheight) {
      //FIXME-SKIN
      this.$.bodyParent.setStyle('max-height: ' + this.maxheight + ';');
}


So then, if a new component extends from OB.UI.Modal and have a maxheight but not a bodyParent, the login fails in this code.
Also, in the upgrade to 20Q1 we are not allowing set styles in this way. The correct approach to do that is apply the maxheight using CSS.
Steps To Reproduce1.- Create a new component that extends from OB.UI.Modal
2.- Define a maxheight but not a bodyParent
3.- Try to do login in the WebPOS
TagsNo tags attached.
Attached Filesdiff file icon maxHeightApplyStyleRemoveOBUIModal.diff [^] (582 bytes) 2020-03-11 09:12 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0120124)
hgbot (developer)
2020-05-21 12:09

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d7d9374287533364e3f4cfef216d3b70bb5490f7
Author: Prakash M <prakash <at> qualiantech.com>
Date: Thu May 21 15:39:03 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d7d9374287533364e3f4cfef216d3b70bb5490f7 [^]

Fixed BUG-43475: Extending OB.UI.Modal with maxheight defined and without
bodyParent causes js error

As per new skin implementation setting maxheight to bodyParent is not needed.
Also styles should not be applied statically in new skin.
Styles should be applied through css class.

Removed this part of code.

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
---

- Issue History
Date Modified Username Field Change
2020-03-11 09:12 kchoperena New Issue
2020-03-11 09:12 kchoperena Assigned To => Retail
2020-03-11 09:12 kchoperena File Added: maxHeightApplyStyleRemoveOBUIModal.diff
2020-03-11 09:12 kchoperena Resolution time => 1585090800
2020-03-11 09:12 kchoperena Triggers an Emergency Pack => No
2020-05-05 12:08 rafademiguel Priority normal => high
2020-05-05 16:02 marvintm Resolution time 1585090800 => 1590444000
2020-05-05 16:02 marvintm Type design defect => defect
2020-05-21 07:24 prakashmurugesan88 Assigned To Retail => prakashmurugesan88
2020-05-21 07:24 prakashmurugesan88 Status new => scheduled
2020-05-21 12:09 hgbot Checkin
2020-05-21 12:09 hgbot Note Added: 0120124
2020-05-21 12:09 hgbot Status scheduled => resolved
2020-05-21 12:09 hgbot Resolution open => fixed
2020-05-21 12:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d7d9374287533364e3f4cfef216d3b70bb5490f7 [^]
2020-05-25 08:16 marvintm Review Assigned To => marvintm
2020-05-25 08:16 marvintm Status resolved => closed
2020-05-25 08:16 marvintm Fixed in Version => RR20Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker