Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043411
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-03-04 08:562020-03-11 11:20
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision5945c28b65c2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043411: Apply new HQL Style in FinancialUtils.java

DescriptionFinancialUtils.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0118314)
inigo_lerga (viewer)
2020-03-04 10:08

 --Test Plan Mantis HQL queries--
For this query to get executed, Execute the TestCosting.java JUnit tests.
#In this moment one of the modified HQLs is executed#

As the F&B International Group Admin role:
  - Go to the Business Partner window and open the
    "Alimentos y Supermercados, S.A" record.
    Press the Set New Currency button.
  
  #In this moment the second modified HQL is executed#
(0118503)
hgbot (developer)
2020-03-11 11:19

 Repository: erp/devel/pi
Changeset: 5945c28b65c235e44ce9016ba8ce2b41fbf67c76
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Mar 04 10:11:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5945c28b65c235e44ce9016ba8ce2b41fbf67c76 [^]

fixes BUG-43411:Applied new HQL Style

---
M src/org/openbravo/financial/FinancialUtils.java
---
(0118504)
hgbot (developer)
2020-03-11 11:19

 Repository: erp/devel/pi
Changeset: d04832b1bcf2a7b8775f70c14ff9b6a0ce5c4cff
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Mar 04 10:51:02 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d04832b1bcf2a7b8775f70c14ff9b6a0ce5c4cff [^]

related to ISSUE-43411: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

---
M src/org/openbravo/financial/FinancialUtils.java
---
(0118505)
dmiguelez (viewer)
2020-03-11 11:20

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-03-04 08:56 inigo_lerga New Issue
2020-03-04 08:56 inigo_lerga Assigned To => inigo_lerga
2020-03-04 08:56 inigo_lerga OBNetwork customer => No
2020-03-04 08:56 inigo_lerga Modules => Core
2020-03-04 08:56 inigo_lerga Triggers an Emergency Pack => No
2020-03-04 08:56 inigo_lerga Relationship added related to 0041287
2020-03-04 08:57 inigo_lerga Status new => scheduled
2020-03-04 10:08 inigo_lerga Note Added: 0118314
2020-03-11 11:19 hgbot Checkin
2020-03-11 11:19 hgbot Note Added: 0118503
2020-03-11 11:19 hgbot Status scheduled => resolved
2020-03-11 11:19 hgbot Resolution open => fixed
2020-03-11 11:19 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5945c28b65c235e44ce9016ba8ce2b41fbf67c76 [^]
2020-03-11 11:19 hgbot Checkin
2020-03-11 11:19 hgbot Note Added: 0118504
2020-03-11 11:20 dmiguelez Review Assigned To => dmiguelez
2020-03-11 11:20 dmiguelez Note Added: 0118505
2020-03-11 11:20 dmiguelez Status resolved => closed
2020-03-11 11:20 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker