Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043394
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-03-03 10:042020-03-06 14:31
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision345e75647853
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043394: Apply new HQL Style in InvoiceEventHandler.java

DescriptionInvoiceEventHandler.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0118293)
inigo_lerga (viewer)
2020-03-03 12:22

 --Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Purchase Invoice window and create
    a new record. Select any Business Partner desired.
    Save the record.
    Now change the Business Partner to a different one
    ans save again.
  
  #In this moment the modified HQL is executed#
(0118392)
hgbot (developer)
2020-03-06 14:30

 Repository: erp/devel/pi
Changeset: 345e756478535b0254cd5a9b2f0a5dee433eb8fc
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 11:14:42 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/345e756478535b0254cd5a9b2f0a5dee433eb8fc [^]

fixes BUG-43394:Applied new HQL Style

---
M src/org/openbravo/event/InvoiceEventHandler.java
---
(0118393)
hgbot (developer)
2020-03-06 14:30

 Repository: erp/devel/pi
Changeset: c65a5e95a092a30669d9a4a1f1aee4c424eb62dc
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 11:18:01 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c65a5e95a092a30669d9a4a1f1aee4c424eb62dc [^]

related to ISSUE-43394: Finals added
-Finals added
-No sonarlint suggestions found

---
M src/org/openbravo/event/InvoiceEventHandler.java
---
(0118394)
dmiguelez (viewer)
2020-03-06 14:31

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-03-03 10:04 inigo_lerga New Issue
2020-03-03 10:04 inigo_lerga Assigned To => inigo_lerga
2020-03-03 10:04 inigo_lerga OBNetwork customer => No
2020-03-03 10:04 inigo_lerga Modules => Core
2020-03-03 10:04 inigo_lerga Triggers an Emergency Pack => No
2020-03-03 10:05 inigo_lerga Relationship added related to 0041287
2020-03-03 10:05 inigo_lerga Status new => scheduled
2020-03-03 12:22 inigo_lerga Note Added: 0118293
2020-03-06 14:30 hgbot Checkin
2020-03-06 14:30 hgbot Note Added: 0118392
2020-03-06 14:30 hgbot Status scheduled => resolved
2020-03-06 14:30 hgbot Resolution open => fixed
2020-03-06 14:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/345e756478535b0254cd5a9b2f0a5dee433eb8fc [^]
2020-03-06 14:30 hgbot Checkin
2020-03-06 14:30 hgbot Note Added: 0118393
2020-03-06 14:31 dmiguelez Review Assigned To => dmiguelez
2020-03-06 14:31 dmiguelez Note Added: 0118394
2020-03-06 14:31 dmiguelez Status resolved => closed
2020-03-06 14:31 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker