Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043381
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-03-02 12:132020-03-06 13:38
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision254835a62473
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043381: Apply new HQL Style in DimensionDisplayUtility.java

DescriptionDimensionDisplayUtility.java has eight HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Tracking issue: Convert HQL to apply new style 

-  Notes
(0118249)
inigo_lerga (developer)
2020-03-02 14:01

--Test Plan Mantis HQL queries--
The first query is executed when the Openbravo instance is
open in the web browser.

As the F&B International Group Admin role:
  - Go to the Purchase Invoice window.
  
  #In this moment three of the modified HQLs are executed#

  - Go to the Financial Account window.

  #In this moment two of the modified HQLs are executed#

As the System Administrator role:
  - Go to the Initial Client Setup and select USD as Currency.
    Put any desired Password and Confirmed Password.
    Uncheck the Include accounting checkbox.
    Press the OK button.

  #In this moment the last modified HQL is executed#
(0118376)
hgbot (developer)
2020-03-06 13:37

Repository: erp/devel/pi
Changeset: 254835a6247340fa54c2f1a5a20a3668f439f0e8
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 02 13:50:33 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/254835a6247340fa54c2f1a5a20a3668f439f0e8 [^]

fixes BUG-43381:Applied new HQL Style

---
M src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java
---
(0118377)
hgbot (developer)
2020-03-06 13:37

Repository: erp/devel/pi
Changeset: 2f27b3d81a1716dde7ba949b82a59fdedb0c4945
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 02 14:43:26 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2f27b3d81a1716dde7ba949b82a59fdedb0c4945 [^]

related to ISSUE-43381: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

---
M src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java
---
(0118378)
dmiguelez (developer)
2020-03-06 13:38

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-03-02 12:13 inigo_lerga New Issue
2020-03-02 12:13 inigo_lerga Assigned To => inigo_lerga
2020-03-02 12:13 inigo_lerga Modules => Core
2020-03-02 12:13 inigo_lerga Triggers an Emergency Pack => No
2020-03-02 12:13 inigo_lerga Status new => scheduled
2020-03-02 12:13 inigo_lerga Relationship added related to 0041287
2020-03-02 14:01 inigo_lerga Note Added: 0118249
2020-03-06 13:37 hgbot Checkin
2020-03-06 13:37 hgbot Note Added: 0118376
2020-03-06 13:37 hgbot Status scheduled => resolved
2020-03-06 13:37 hgbot Resolution open => fixed
2020-03-06 13:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/254835a6247340fa54c2f1a5a20a3668f439f0e8 [^]
2020-03-06 13:37 hgbot Checkin
2020-03-06 13:37 hgbot Note Added: 0118377
2020-03-06 13:38 dmiguelez Review Assigned To => dmiguelez
2020-03-06 13:38 dmiguelez Note Added: 0118378
2020-03-06 13:38 dmiguelez Status resolved => closed
2020-03-06 13:38 dmiguelez Fixed in Version => 3.0PR20Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker