Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043298
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-24 10:592020-03-02 18:33
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision0102ce9fec17
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043298: Apply new HQL Style in AssetLinearDepreciationMethodProcess.java

DescriptionAssetLinearDepreciationMethodProcess.java has three HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0118054)
inigo_lerga (viewer)
2020-02-24 12:46

 --Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Assets window and select the "Storage"
    record. Press the Create Amortization button
    and OK button in the popup window.
  
  #In this moment the modified HQLs are executed#
(0118261)
hgbot (developer)
2020-03-02 16:48

 Repository: erp/devel/pi
Changeset: 0102ce9fec17a85247b8cb067c6de5a0ae36e11b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 24 12:47:22 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0102ce9fec17a85247b8cb067c6de5a0ae36e11b [^]

fixes BUG-43298:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---
(0118262)
hgbot (developer)
2020-03-02 16:48

 Repository: erp/devel/pi
Changeset: f66975bddbda4123103c7fb4c2553b7744329d7f
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 24 14:02:46 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f66975bddbda4123103c7fb4c2553b7744329d7f [^]

related to ISSUE-43298: Applied Sonarlint suggestions + finals added

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---
(0118263)
hgbot (developer)
2020-03-02 16:48

 Repository: erp/devel/pi
Changeset: 0081cfb108afda2e064360af2a396030fcc3f373
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 02 16:47:52 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0081cfb108afda2e064360af2a396030fcc3f373 [^]

Related to ISSUE-43298. Moved parameter in query to avoid unnecessary
format enablers/disablers

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---
(0118264)
dmiguelez (viewer)
2020-03-02 16:49

 Code Review + Testing Ok
(0118272)
hgbot (developer)
2020-03-02 18:33

 Repository: erp/devel/pi
Changeset: cb93d1d1453f03112ea0da6564474f71f5ecae50
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 02 18:32:22 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cb93d1d1453f03112ea0da6564474f71f5ecae50 [^]

Related to ISSUE-43298. Adds accidentaly removed Exception thrown

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---

- Issue History
Date Modified Username Field Change
2020-02-24 10:59 inigo_lerga New Issue
2020-02-24 10:59 inigo_lerga Assigned To => inigo_lerga
2020-02-24 10:59 inigo_lerga OBNetwork customer => No
2020-02-24 10:59 inigo_lerga Modules => Core
2020-02-24 10:59 inigo_lerga Triggers an Emergency Pack => No
2020-02-24 10:59 inigo_lerga Relationship added related to 0041287
2020-02-24 11:00 inigo_lerga Status new => scheduled
2020-02-24 12:46 inigo_lerga Note Added: 0118054
2020-03-02 16:48 hgbot Checkin
2020-03-02 16:48 hgbot Note Added: 0118261
2020-03-02 16:48 hgbot Status scheduled => resolved
2020-03-02 16:48 hgbot Resolution open => fixed
2020-03-02 16:48 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0102ce9fec17a85247b8cb067c6de5a0ae36e11b [^]
2020-03-02 16:48 hgbot Checkin
2020-03-02 16:48 hgbot Note Added: 0118262
2020-03-02 16:48 hgbot Checkin
2020-03-02 16:48 hgbot Note Added: 0118263
2020-03-02 16:49 dmiguelez Review Assigned To => dmiguelez
2020-03-02 16:49 dmiguelez Note Added: 0118264
2020-03-02 16:49 dmiguelez Status resolved => closed
2020-03-02 16:49 dmiguelez Fixed in Version => 3.0PR20Q2
2020-03-02 18:33 hgbot Checkin
2020-03-02 18:33 hgbot Note Added: 0118272

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker