Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043278
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-20 12:532020-03-02 15:59
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revisionaa65f11ee253
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043278: Apply new HQL Style in DocLineCashVATReady_PaymentTransactionReconciliation.java

DescriptionDocLineCashVATReady_PaymentTransactionReconciliation.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Tracking issue: Convert HQL to apply new style 

-  Notes
(0117971)
inigo_lerga (developer)
2020-02-20 14:15
edited on: 2020-02-20 14:29

--Test Plan Mantis HQL queries--
First of all, to execute this query it is needed to
have installed the Cash VAT Management module.

As the F&B International Group Admin role:
  - Go to the Process Request window and Unschedule
    the Acct Server Process.
    Create a new record with the "Acct Server Process"
    Process and "Run Immediately" as Timing.
  - Go to the Organization window and enter the
    "F&B US, Inc." record. Open its Information Tab
    line and check the Cash VAT checkbox.
  - Go now to the Sales Order window and create a
    new record with "Alimentos y Supermercados, S.A"
    as Business Partner.
    Go to the Lines Tab and create a new one with
    "Cerveza Ale 0,5L" as Product and 40 units in
    Ordered Quantity.
    Press the Book button and OK in the popup window.
    Press the Add Payment button and Done in the
    popup window.
  - Go back to the Process Request window and Schedule
    the previously created Process.
  
  #In this moment the modified HQLs are executed#

(0118253)
hgbot (developer)
2020-03-02 15:58

Repository: erp/devel/pi
Changeset: aa65f11ee2533f45ae8f902e9a0b85c31a58c968
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Feb 20 14:18:09 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aa65f11ee2533f45ae8f902e9a0b85c31a58c968 [^]

fixes BUG-43278:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_forms/DocLineCashVATReady_PaymentTransactionReconciliation.java
---
(0118254)
hgbot (developer)
2020-03-02 15:58

Repository: erp/devel/pi
Changeset: f0903f85d3b657b39d6ce2342de593a30085be54
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Feb 20 14:30:23 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f0903f85d3b657b39d6ce2342de593a30085be54 [^]

related to ISSUE-43278: Applied Sonarlint suggestions and more

Sonarlint suggestions applied.
Finals added.

---
M src/org/openbravo/erpCommon/ad_forms/DocLineCashVATReady_PaymentTransactionReconciliation.java
---
(0118255)
dmiguelez (developer)
2020-03-02 15:59

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-02-20 12:53 inigo_lerga New Issue
2020-02-20 12:53 inigo_lerga Assigned To => platform
2020-02-20 12:53 inigo_lerga Modules => Core
2020-02-20 12:53 inigo_lerga Triggers an Emergency Pack => No
2020-02-20 14:14 inigo_lerga Assigned To platform => inigo_lerga
2020-02-20 14:14 inigo_lerga Status new => scheduled
2020-02-20 14:15 inigo_lerga Note Added: 0117971
2020-02-20 14:29 inigo_lerga Note Edited: 0117971 View Revisions
2020-02-20 15:35 inigo_lerga Relationship added related to 0041287
2020-03-02 15:58 hgbot Checkin
2020-03-02 15:58 hgbot Note Added: 0118253
2020-03-02 15:58 hgbot Status scheduled => resolved
2020-03-02 15:58 hgbot Resolution open => fixed
2020-03-02 15:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aa65f11ee2533f45ae8f902e9a0b85c31a58c968 [^]
2020-03-02 15:58 hgbot Checkin
2020-03-02 15:58 hgbot Note Added: 0118254
2020-03-02 15:59 dmiguelez Review Assigned To => dmiguelez
2020-03-02 15:59 dmiguelez Note Added: 0118255
2020-03-02 15:59 dmiguelez Status resolved => closed
2020-03-02 15:59 dmiguelez Fixed in Version => 3.0PR20Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker