Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043180
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformminoralways2020-02-10 19:322020-04-06 15:45
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision2ecdf5dcd7b3
ProjectionnoneETAnoneTarget Version3.0PR20Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojarmendariz
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2018-10-30
Regression introduced in release3.0PR19Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/dbsm/-/commit/789aa22ca2be4190e5f07a4770c2172e0e5c0552 [^]
Triggers an Emergency PackNo
Summary

0043180: Update.database message about local changes in application dictionary is missing table name

DescriptionThe update.database mechanism to check for local changes consists of 2 parts:
a.) structure changes
b.) changes in AD

For part b.) the code did show the table having changes also but is no longer doing so -> Regression.

Checking code of code in dbsm-main repo OBDataset.java method hasChanged:
  if (log != null) {
              log.warn("Change detected in table: " + table.getName());

So issue could be either:
- logger being null (even if seems to be set in OBDBSMOBUtil.java)
- logger being not configured to show by default.
Steps To Reproduce1.) Have clean base (i.e. install.source or previous update.database ran)
2.) Cause local change in AD
update ad_window set updated=now() where ad_window_id = '100';
3.) Run update.database

4.) Check output missing info about table
     [java] 18844 [main] INFO org.openbravo.ddlutils.util.DBSMOBUtil - Checking if database structure was modified locally.
     [java] 19425 [main] INFO org.openbravo.ddlutils.util.DBSMOBUtil - Checking if data has changed in the application dictionary.
     [java] 19465 [main] ERROR org.openbravo.ddlutils.task.AlterDatabaseDataAll - Database has local changes. Update.database will not be done. You should export your changed modules before doing update.database, so that your Application Dictionary changes are preserved.
     [java] Database has local changes. Update.database not done.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0043175 closedalostale Update.database message about local changes in application dictionary is missing table name 

-  Notes
(0117899)
hgbot (developer)
2020-02-18 10:13

 Repository: erp/backports/3.0PR20Q1
Changeset: 4ccf709168ed8cf1436a197058064ec550b98332
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 18 10:12:55 2020 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/4ccf709168ed8cf1436a197058064ec550b98332 [^]

fixed BUG-43180: log local changes

  When updating database having local changes in AD, the tables with
  changes were not logged.

  While project to upgrade to log4j2 the API, old API passing old logger
  was kept but it become unusable as null logger was used.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0117900)
alostale (manager)
2020-02-18 10:13

 dbsm commit: https://gitlab.com/openbravo/product/dbsm/-/commit/aef1e32c82874f09bb7f4f2b9d31a3ac6965e3ed [^]
(0117937)
jarmendariz (developer)
2020-02-19 09:44

 Reviewed
(0118962)
hgbot (developer)
2020-04-06 11:53

 Repository: erp/devel/pi
Changeset: 2ecdf5dcd7b3908eaf7c2d88c6d31215c4320e8a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 18 10:12:55 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2ecdf5dcd7b3908eaf7c2d88c6d31215c4320e8a [^]

fixed BUG-43180: log local changes

  When updating database having local changes in AD, the tables with
  changes were not logged.

  While project to upgrade to log4j2 the API, old API passing old logger
  was kept but it become unusable as null logger was used.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0118987)
cberner (developer)
2020-04-06 15:45

 closed: wrongly reopened

- Issue History
Date Modified Username Field Change
2020-02-11 10:39 alostale Type defect => backport
2020-02-11 10:39 alostale Target Version => 3.0PR20Q1
2020-02-18 10:13 hgbot Checkin
2020-02-18 10:13 hgbot Note Added: 0117899
2020-02-18 10:13 hgbot Status scheduled => resolved
2020-02-18 10:13 hgbot Resolution open => fixed
2020-02-18 10:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/4ccf709168ed8cf1436a197058064ec550b98332 [^]
2020-02-18 10:13 alostale Note Added: 0117900
2020-02-19 09:44 jarmendariz Note Added: 0117937
2020-02-19 09:44 jarmendariz Status resolved => closed
2020-04-06 11:53 hgbot Checkin
2020-04-06 11:53 hgbot Note Added: 0118962
2020-04-06 11:53 hgbot Status closed => resolved
2020-04-06 11:53 hgbot Fixed in SCM revision http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/4ccf709168ed8cf1436a197058064ec550b98332 [^] => http://code.openbravo.com/erp/devel/pi/rev/2ecdf5dcd7b3908eaf7c2d88c6d31215c4320e8a [^]
2020-04-06 15:45 cberner Note Added: 0118987
2020-04-06 15:45 cberner Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker