Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043099
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-03 12:272020-02-07 13:29
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revisionacfc762fe329
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043099: Apply new HQL Style in InventoryAmountUpdateProcess.java

DescriptionInventoryAmountUpdateProcess.java has 3 HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Tracking issue: Convert HQL to apply new style 

-  Notes
(0117430)
inigo_lerga (developer)
2020-02-03 14:23

Test Plan Mantis HQL queries:
As the F&B International Group Admin role:
    - Go to the Inventory Amount Update window and
      create a new record. Leave every field as default.
    - Save the record.
    - Go to the Lines Tab and create a new record with
      "Cerveza Ale 0,5L" as Product. Leave every other
      field as default.
    - Save the record.
    - Press the Process button and Done button in the popup
      window.
    #In this moment modified HQLs are executed#
(0117567)
hgbot (developer)
2020-02-07 13:28

Repository: erp/devel/pi
Changeset: acfc762fe329f9a89ce2e70cc2e2bf71dd4ec66e
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 03 16:28:24 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/acfc762fe329f9a89ce2e70cc2e2bf71dd4ec66e [^]

fixes BUG-43099:Applied new HQL Style

---
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0117568)
hgbot (developer)
2020-02-07 13:28

Repository: erp/devel/pi
Changeset: e2afe6eb1f2e50d287120ab54834422baf2754fa
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 03 16:52:07 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e2afe6eb1f2e50d287120ab54834422baf2754fa [^]

related to ISSUE-43099: Applied Sonarlint suggestions

---
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0117569)
hgbot (developer)
2020-02-07 13:28

Repository: erp/devel/pi
Changeset: 1023e25134e1c2a7d0b36ae5fccb0510c1ac9175
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 07 13:28:26 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1023e25134e1c2a7d0b36ae5fccb0510c1ac9175 [^]

Related to ISSUE-43099: Code Review changes
* Use ids instead of objects in hql query
* Changed names of variables to better reflect
  that they refer to ids

---
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0117570)
dmiguelez (developer)
2020-02-07 13:29

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-02-03 12:27 inigo_lerga New Issue
2020-02-03 12:27 inigo_lerga Assigned To => platform
2020-02-03 12:27 inigo_lerga Modules => Core
2020-02-03 12:27 inigo_lerga Triggers an Emergency Pack => No
2020-02-03 12:27 inigo_lerga Assigned To platform => inigo_lerga
2020-02-03 12:27 inigo_lerga Status new => scheduled
2020-02-03 12:28 inigo_lerga Relationship added related to 0041287
2020-02-03 14:23 inigo_lerga Note Added: 0117430
2020-02-07 13:28 hgbot Checkin
2020-02-07 13:28 hgbot Note Added: 0117567
2020-02-07 13:28 hgbot Status scheduled => resolved
2020-02-07 13:28 hgbot Resolution open => fixed
2020-02-07 13:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/acfc762fe329f9a89ce2e70cc2e2bf71dd4ec66e [^]
2020-02-07 13:28 hgbot Checkin
2020-02-07 13:28 hgbot Note Added: 0117568
2020-02-07 13:28 hgbot Checkin
2020-02-07 13:28 hgbot Note Added: 0117569
2020-02-07 13:29 dmiguelez Review Assigned To => dmiguelez
2020-02-07 13:29 dmiguelez Note Added: 0117570
2020-02-07 13:29 dmiguelez Status resolved => closed
2020-02-07 13:29 dmiguelez Fixed in Version => 3.0PR20Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker