Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043097
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-03 12:162020-02-07 12:44
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionf9730e18aba5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043097: Apply new HQL Style in FixBackdatedTransactionsProcess.java

DescriptionFixBackdatedTransactionsProcess.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0117429)
inigo_lerga (viewer)
2020-02-03 13:02

 Test Plan Mantis HQL queries:
As the F&B International Group Admin role:
    - Go to the Costing Rules window and select
      the one with "F&B US, Inc." as organization.
      Press the Fix Backdated Transactions button
      and Done button.
    #In this moment the middle modified HQL is executed#
(0117563)
hgbot (developer)
2020-02-07 12:43

 Repository: erp/devel/pi
Changeset: f9730e18aba5ee5fb55e36bf91f4096a8544104d
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Feb 03 13:19:32 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f9730e18aba5ee5fb55e36bf91f4096a8544104d [^]

fixes BUG-43097:Applied new HQL Style + final added

---
M src/org/openbravo/costing/FixBackdatedTransactionsProcess.java
---
(0117564)
hgbot (developer)
2020-02-07 12:43

 Repository: erp/devel/pi
Changeset: 940471140131062ecb0a4cbda8c90206c8bda20d
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 07 12:43:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/940471140131062ecb0a4cbda8c90206c8bda20d [^]

Related to ISSUE-43097. Changed variable name to better reflect
that is a list of ids

---
M src/org/openbravo/costing/FixBackdatedTransactionsProcess.java
---
(0117565)
dmiguelez (viewer)
2020-02-07 12:44

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-02-03 12:16 inigo_lerga New Issue
2020-02-03 12:16 inigo_lerga Assigned To => inigo_lerga
2020-02-03 12:16 inigo_lerga OBNetwork customer => No
2020-02-03 12:16 inigo_lerga Modules => Core
2020-02-03 12:16 inigo_lerga Triggers an Emergency Pack => No
2020-02-03 12:17 inigo_lerga Status new => acknowledged
2020-02-03 12:17 inigo_lerga Description Updated View Revisions
2020-02-03 12:17 inigo_lerga Status acknowledged => scheduled
2020-02-03 12:17 inigo_lerga Relationship added related to 0041287
2020-02-03 13:02 inigo_lerga Note Added: 0117429
2020-02-07 12:43 hgbot Checkin
2020-02-07 12:43 hgbot Note Added: 0117563
2020-02-07 12:43 hgbot Status scheduled => resolved
2020-02-07 12:43 hgbot Resolution open => fixed
2020-02-07 12:43 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f9730e18aba5ee5fb55e36bf91f4096a8544104d [^]
2020-02-07 12:43 hgbot Checkin
2020-02-07 12:43 hgbot Note Added: 0117564
2020-02-07 12:44 dmiguelez Review Assigned To => dmiguelez
2020-02-07 12:44 dmiguelez Note Added: 0117565
2020-02-07 12:44 dmiguelez Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker