Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0042925
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-01-17 10:212020-02-06 17:17
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revisione9e7c068f287
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042925: Apply new HQL Style in AverageAlgorithm.java

DescriptionAverageAlgorithm.java has three HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Tracking issue: Convert HQL to apply new style 

-  Notes
(0117033)
inigo_lerga (developer)
2020-01-17 14:41

Test Plan Mantis HQL queries:
As the F&B International Group Admin role:
    - Go to the Process Request window and
      create a new record with * as Organization.
      Put Costing Background Process in the Process
      field ans save the record.
    - Go to the Product window and create a new record.
      Put any SearchKey and Name, and select Alcoholic as
      Product Category.
      Create a new Line in the Price Tab and choose the
      "Tarifa Bebidas Alegres" as Price List Version and
      any Unit and List Prices desired. Save the record.
    - Go to the Goods Receipt window and create a new record with
      "Bebidas Alegres, S.L." as Business Partner.
      Create a new Line in the Lines Tab with the previously created
      Product and any Movement Quantity desired. Save the record.
    - Go back to the Process Request window and press the
      Schedule Process button of the previously created Process Request.
    #In this moment the modified HQLs are executed#
(0117527)
hgbot (developer)
2020-02-06 17:17

Repository: erp/devel/pi
Changeset: e9e7c068f287a4a5d1808e41c950b9be7cf0d9f9
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri Jan 17 14:29:23 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e9e7c068f287a4a5d1808e41c950b9be7cf0d9f9 [^]

fixes BUG-42925:Applied new HQL Style

---
M src/org/openbravo/costing/AverageAlgorithm.java
---
(0117528)
dmiguelez (developer)
2020-02-06 17:17

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-01-17 10:21 inigo_lerga New Issue
2020-01-17 10:21 inigo_lerga Assigned To => inigo_lerga
2020-01-17 10:21 inigo_lerga Modules => Core
2020-01-17 10:21 inigo_lerga Triggers an Emergency Pack => No
2020-01-17 10:21 inigo_lerga Status new => scheduled
2020-01-17 10:22 inigo_lerga Relationship added related to 0041287
2020-01-17 14:41 inigo_lerga Note Added: 0117033
2020-02-06 17:17 hgbot Checkin
2020-02-06 17:17 hgbot Note Added: 0117527
2020-02-06 17:17 hgbot Status scheduled => resolved
2020-02-06 17:17 hgbot Resolution open => fixed
2020-02-06 17:17 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e9e7c068f287a4a5d1808e41c950b9be7cf0d9f9 [^]
2020-02-06 17:17 dmiguelez Review Assigned To => dmiguelez
2020-02-06 17:17 dmiguelez Note Added: 0117528
2020-02-06 17:17 dmiguelez Status resolved => closed
2020-02-06 17:17 dmiguelez Fixed in Version => 3.0PR20Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker