Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0042925 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2020-01-17 10:21 | 2020-02-06 17:17 | |||
| Reporter | inigo_lerga | View Status | public | |||||
| Assigned To | inigo_lerga | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR20Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e9e7c068f287 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | dmiguelez | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0042925: Apply new HQL Style in AverageAlgorithm.java | |||||||
| Description | AverageAlgorithm.java has three HQL queries with: - the HQL is hard to read because of formatting - and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
Notes |
|
|
(0117033) inigo_lerga (viewer) 2020-01-17 14:41 |
Test Plan Mantis HQL queries: As the F&B International Group Admin role: - Go to the Process Request window and create a new record with * as Organization. Put Costing Background Process in the Process field ans save the record. - Go to the Product window and create a new record. Put any SearchKey and Name, and select Alcoholic as Product Category. Create a new Line in the Price Tab and choose the "Tarifa Bebidas Alegres" as Price List Version and any Unit and List Prices desired. Save the record. - Go to the Goods Receipt window and create a new record with "Bebidas Alegres, S.L." as Business Partner. Create a new Line in the Lines Tab with the previously created Product and any Movement Quantity desired. Save the record. - Go back to the Process Request window and press the Schedule Process button of the previously created Process Request. #In this moment the modified HQLs are executed# |
|
(0117527) hgbot (developer) 2020-02-06 17:17 |
Repository: erp/devel/pi Changeset: e9e7c068f287a4a5d1808e41c950b9be7cf0d9f9 Author: IƱigo Lerga <inigo.lerga <at> openbravo.com> Date: Fri Jan 17 14:29:23 2020 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/e9e7c068f287a4a5d1808e41c950b9be7cf0d9f9 [^] fixes BUG-42925:Applied new HQL Style --- M src/org/openbravo/costing/AverageAlgorithm.java --- |
|
(0117528) dmiguelez (viewer) 2020-02-06 17:17 |
Code Review + Testing Ok |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-01-17 10:21 | inigo_lerga | New Issue | |
| 2020-01-17 10:21 | inigo_lerga | Assigned To | => inigo_lerga |
| 2020-01-17 10:21 | inigo_lerga | OBNetwork customer | => No |
| 2020-01-17 10:21 | inigo_lerga | Modules | => Core |
| 2020-01-17 10:21 | inigo_lerga | Triggers an Emergency Pack | => No |
| 2020-01-17 10:21 | inigo_lerga | Status | new => scheduled |
| 2020-01-17 10:22 | inigo_lerga | Relationship added | related to 0041287 |
| 2020-01-17 14:41 | inigo_lerga | Note Added: 0117033 | |
| 2020-02-06 17:17 | hgbot | Checkin | |
| 2020-02-06 17:17 | hgbot | Note Added: 0117527 | |
| 2020-02-06 17:17 | hgbot | Status | scheduled => resolved |
| 2020-02-06 17:17 | hgbot | Resolution | open => fixed |
| 2020-02-06 17:17 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e9e7c068f287a4a5d1808e41c950b9be7cf0d9f9 [^] |
| 2020-02-06 17:17 | dmiguelez | Review Assigned To | => dmiguelez |
| 2020-02-06 17:17 | dmiguelez | Note Added: 0117528 | |
| 2020-02-06 17:17 | dmiguelez | Status | resolved => closed |
| 2020-02-06 17:17 | dmiguelez | Fixed in Version | => 3.0PR20Q2 |
| Copyright © 2000 - 2009 MantisBT Group |