0042892: [20Q1] [UX] The "Edit" top menu option keeps enabled after paying an open ticket

Description

The top-right "Edit" button, used to edit lines, is disabled when the ticket has no lines.
However, after the ticket is paid using the "Pay open tickets" feature, the button remains active (no action possible though)

This is also reproducible in 19Q4 and previous, it is not specific to this release.

Steps To Reproduce

Enter the webPOS.
Notice that, since there are no lines in the empty ticket, the top right Edit button is disabled as expected.
Add a product to the ticket
Notice now the button is enabled as expected.
Go to "Pay Open tickets" option in the main menu and fully pay the ticket
The window shows only a new empty ticket, since the previous ticket has been paid, but the Edit button is still enabled.

Proposed Solution

**************************
* Attached fix proposal *
**************************

Tags

No tags attached.

Attached Files

PayOpenTickets.png [^] (354,286 bytes) 2020-01-15 15:56

issue42892_editMenuOptionEnabled_posterminal.patch [^] (1,249 bytes) 2021-11-18 13:01 [Show Content] [Hide Content]

From 6f0c65184e3f18978615c6ff8a921b4e0c36a2ac Mon Sep 17 00:00:00 2001
From: Beatriz Lago <beatrizlago@openbravo.com>
Date: Mon, 15 Nov 2021 10:38:03 +0100
Subject: [PATCH] Fixed ISSUE-42892: The Edit top menu option keeps enabled
 after paying an open ticket.

In toolbar-right.js, in the declaration of the enyo object OB.OBPOSPointOfSale.UI.ButtonTabEditLine
(line 530), added a disableButton handler for the onFinishServiceProposal event.
---
 .../js/pointofsale/view/toolbar-right.js                       | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
index 30b59106b..881494627 100644
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
@@ -548,7 +548,8 @@ enyo.kind({
   },
   handlers: {
     onRightToolbarDisabled: 'disableButton',
-    onManageServiceProposal: 'manageServiceProposal'
+    onManageServiceProposal: 'manageServiceProposal',
+    onFinishServiceProposal: 'disableButton'
   },
   init: function(model) {
     this.model = model;
-- 
GitLab

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0132157) hgbot (developer) 2021-10-05 09:37	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/587 [^]

(0132239) hgbot (developer) 2021-10-07 10:39	Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/587 [^]

Issue History
Date Modified	Username	Field	Change
2020-01-15 15:56	plujan	New Issue
2020-01-15 15:56	plujan	Assigned To	=> Retail
2020-01-15 15:56	plujan	File Added: PayOpenTickets.png
2020-01-15 15:56	plujan	OBNetwork customer	=> No
2020-01-15 15:56	plujan	Triggers an Emergency Pack	=> No
2021-10-05 09:37	hgbot	Merge Request Status	=> open
2021-10-05 09:37	hgbot	Note Added: 0132157
2021-10-07 10:39	hgbot	Note Added: 0132239
2021-11-18 13:01	beatriz_lago	Status	new => acknowledged
2021-11-18 13:01	beatriz_lago	File Added: issue42892_editMenuOptionEnabled_posterminal.patch
2021-11-18 13:02	beatriz_lago	Proposed Solution updated