Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0042878
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-01-15 09:342020-01-20 18:23
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revisione21a59b12235
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042878: Apply new HQL Style in UpdatePricesAndAmounts.java

DescriptionUpdateInvoiceLineInformation.java has two HQL queries with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Tracking issue: Convert HQL to apply new style 

-  Notes
(0116897)
inigo_lerga (developer)
2020-01-15 13:22

Test Plan Mantis:
As the F&B International Group Admin role, F&B US, Inc. as Organization
and Warehouse US East Coast:
    - Go to the Goods Shipment window and create
      a new record with "Moon Light Restaurants, Co."
      as Business Partner.
    - Go to the Lines Tab and create a new record with
      "Lager Beer" product and 10 units in Movement Quantity
      field.
    - Save the record and press the Complete button. In the
      popup window press the OK button taking into account
      that the Invoice if possible checkbox is not checked.
    - Go to the Sales Invoice window and create a new record
      with "Moon Light Restaurants, Co." as Business Partner.
      Click the Create Lines From Shipment button and select
      the previously created Goods Shipment. Press the Done
      button.
      
#In this moment the modified HQL is executed#
(0117098)
hgbot (developer)
2020-01-20 18:23

Repository: erp/devel/pi
Changeset: e21a59b122350c0728b44d9ba323920e84d8eaf7
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Jan 15 13:23:43 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e21a59b122350c0728b44d9ba323920e84d8eaf7 [^]

fixes BUG-42878:Applied new HQL Style

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdatePricesAndAmounts.java
---
(0117099)
hgbot (developer)
2020-01-20 18:23

Repository: erp/devel/pi
Changeset: 05eb9a97dc3b54559af57832e328fbf0508fcbb2
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 20 18:22:55 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/05eb9a97dc3b54559af57832e328fbf0508fcbb2 [^]

Related to ISSUE-42878: Code Review changes:
* Do not use Boolean.TRUE, keep old comparison as the code
is more redable
* Select word in query must be lowercase

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdatePricesAndAmounts.java
---
(0117100)
dmiguelez (developer)
2020-01-20 18:23

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-01-15 09:34 inigo_lerga New Issue
2020-01-15 09:34 inigo_lerga Assigned To => inigo_lerga
2020-01-15 09:34 inigo_lerga Modules => Core
2020-01-15 09:34 inigo_lerga Triggers an Emergency Pack => No
2020-01-15 09:34 inigo_lerga Relationship added related to 0041287
2020-01-15 11:42 inigo_lerga Status new => scheduled
2020-01-15 13:22 inigo_lerga Note Added: 0116897
2020-01-20 18:23 hgbot Checkin
2020-01-20 18:23 hgbot Note Added: 0117098
2020-01-20 18:23 hgbot Status scheduled => resolved
2020-01-20 18:23 hgbot Resolution open => fixed
2020-01-20 18:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e21a59b122350c0728b44d9ba323920e84d8eaf7 [^]
2020-01-20 18:23 hgbot Checkin
2020-01-20 18:23 hgbot Note Added: 0117099
2020-01-20 18:23 dmiguelez Review Assigned To => dmiguelez
2020-01-20 18:23 dmiguelez Note Added: 0117100
2020-01-20 18:23 dmiguelez Status resolved => closed
2020-01-20 18:23 dmiguelez Fixed in Version => 3.0PR20Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker