Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042845
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-01-14 12:392020-01-20 13:40
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision3e653c96fb2c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042845: Apply new HQL Style in APRM_MatchingUtility.java

DescriptionAPRM_MatchingUtility.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0116856)
inigo_lerga (viewer)
2020-01-14 13:41

 Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Financial Account and open
      the "Cuenta de Banco" record.
    - Enter the Imported Bank Statements
      Tab and create a new record. Write
      any name desired and save. Go the
      Bank Statement Lines Tab inside this
      Imported Bank Statement and create a new record
      with the Reference No as "101010" and
      Amount In field with 500.
    - Go back to the Imported Bank Statement
      and press the Process button and OK button
      inside the popup window.
    - Go back to the Financial Account record and
      press the Match Statement button and OK in
      the popup window.
      
#In this moment the modified HQL is executed#
(0117071)
hgbot (developer)
2020-01-20 13:39

 Repository: erp/devel/pi
Changeset: 3e653c96fb2ca6a8a866edc03e950825deee7dcd
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 13:32:33 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3e653c96fb2ca6a8a866edc03e950825deee7dcd [^]

fixes BUG-42845:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRM_MatchingUtility.java
---
(0117072)
hgbot (developer)
2020-01-20 13:39

 Repository: erp/devel/pi
Changeset: 4afe620f4e46f01cbf302349f4aed1f79bc78461
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 13:50:25 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4afe620f4e46f01cbf302349f4aed1f79bc78461 [^]

related to ISSUE-42845: Applied Sonarlint suggestions

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRM_MatchingUtility.java
---
(0117073)
hgbot (developer)
2020-01-20 13:39

 Repository: erp/devel/pi
Changeset: 5d98a003231a7da2359013f15cf51338712d247d
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 20 13:38:15 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5d98a003231a7da2359013f15cf51338712d247d [^]

Related to ISSUE-42845: Code Review changes:
* Do not use Boolean.TRUE, keep old comparison as the code
is more redable

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRM_MatchingUtility.java
---
(0117074)
dmiguelez (viewer)
2020-01-20 13:40

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-01-14 12:39 inigo_lerga New Issue
2020-01-14 12:39 inigo_lerga Assigned To => inigo_lerga
2020-01-14 12:39 inigo_lerga OBNetwork customer => No
2020-01-14 12:39 inigo_lerga Modules => Core
2020-01-14 12:39 inigo_lerga Triggers an Emergency Pack => No
2020-01-14 12:39 inigo_lerga Relationship added related to 0041287
2020-01-14 12:39 inigo_lerga Status new => scheduled
2020-01-14 12:40 inigo_lerga Description Updated View Revisions
2020-01-14 13:00 inigo_lerga Description Updated View Revisions
2020-01-14 13:41 inigo_lerga Note Added: 0116856
2020-01-20 13:39 hgbot Checkin
2020-01-20 13:39 hgbot Note Added: 0117071
2020-01-20 13:39 hgbot Status scheduled => resolved
2020-01-20 13:39 hgbot Resolution open => fixed
2020-01-20 13:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3e653c96fb2ca6a8a866edc03e950825deee7dcd [^]
2020-01-20 13:39 hgbot Checkin
2020-01-20 13:39 hgbot Note Added: 0117072
2020-01-20 13:39 hgbot Checkin
2020-01-20 13:39 hgbot Note Added: 0117073
2020-01-20 13:40 dmiguelez Review Assigned To => dmiguelez
2020-01-20 13:40 dmiguelez Note Added: 0117074
2020-01-20 13:40 dmiguelez Status resolved => closed
2020-01-20 13:40 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker