Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0042831 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | minor | have not tried | 2020-01-09 13:59 | 2020-01-14 10:16 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR19Q4.2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 20dac26b05f2 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR19Q4.2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0042831: ant package.module is missing to exclude .git | |||||||
| Description | The standard ant package.module task used to package modules by developers is missing to exclude .git folder. It currently has excludes for both .hg & .svn but is missing to add same for .git Consequence is it including all git repo history (if present) inside the obx file making them unnecessarily large. On some occasions it can cause later secondary problem with module management as it tries to overwrite some read-only files inside .git in case of updating a module via mmc (having .git inside obx) when older module version also have .git files present. Relevant code to which the new (.git) case should be added: https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/erpCommon/modules/ExtractModule.java#l232 [^] | |||||||
| Steps To Reproduce | Clone any module which is hosted as a git repository and run ant package.module to create obx file. Check obx file (unzip -v) and notice it does contain .git. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0116826) hgbot (developer) 2020-01-14 09:57 |
Repository: erp/backports/3.0PR19Q4.2 Changeset: 20dac26b05f2c52416cd7bf7fc3b20f25e11ec80 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Jan 14 09:06:25 2020 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR19Q4.2/rev/20dac26b05f2c52416cd7bf7fc3b20f25e11ec80 [^] fixed ISSUE-42831: exclude .git directory when packaging modules --- M src/org/openbravo/erpCommon/modules/ExtractModule.java --- |
|
(0116830) caristu (developer) 2020-01-14 10:16 |
Reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-01-14 09:12 | alostale | Type | feature request => backport |
| 2020-01-14 09:12 | alostale | Target Version | => 3.0PR19Q4.2 |
| 2020-01-14 09:57 | hgbot | Checkin | |
| 2020-01-14 09:57 | hgbot | Note Added: 0116826 | |
| 2020-01-14 09:57 | hgbot | Status | scheduled => resolved |
| 2020-01-14 09:57 | hgbot | Resolution | open => fixed |
| 2020-01-14 09:57 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR19Q4.2/rev/20dac26b05f2c52416cd7bf7fc3b20f25e11ec80 [^] |
| 2020-01-14 10:16 | caristu | Note Added: 0116830 | |
| 2020-01-14 10:16 | caristu | Status | resolved => closed |
| 2020-01-14 10:16 | caristu | Fixed in Version | => 3.0PR19Q4.2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |