Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042814
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-01-13 11:322020-01-17 14:18
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revisionca7c137a2054
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042814: Apply new HQL Style in FIN_AddPayment.java

DescriptionFIN_AddPayment.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0116793)
inigo_lerga (viewer)
2020-01-13 12:11

 Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Payment Proposal window and
      select any record. Press the Reactivate
      button and press Process button in the
      popup window.

#In this moment the modified HQL is executed#
(0117025)
hgbot (developer)
2020-01-17 14:17

 Repository: erp/devel/pi
Changeset: ca7c137a2054e2e68b6eb81816e47f5a4ba85e1a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jan 13 12:13:51 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ca7c137a2054e2e68b6eb81816e47f5a4ba85e1a [^]

fixes BUG-42814:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0117026)
hgbot (developer)
2020-01-17 14:17

 Repository: erp/devel/pi
Changeset: 995bdde4ffb5f63ccd1a392d3a3e31470433111b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jan 13 12:37:12 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/995bdde4ffb5f63ccd1a392d3a3e31470433111b [^]

related to ISSUE-42814: Applied Sonarlint suggestions

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0117027)
hgbot (developer)
2020-01-17 14:17

 Repository: erp/devel/pi
Changeset: d98e412837b0a4dafa37d3bd7481321eab7d3529
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 17 14:17:35 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d98e412837b0a4dafa37d3bd7481321eab7d3529 [^]

Related to ISSUE-42814: Code Review Changes:
* Do not use Boolean.TRUE, keep old comparison as the code
  is more redable

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0117028)
dmiguelez (viewer)
2020-01-17 14:18

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-01-13 11:32 inigo_lerga New Issue
2020-01-13 11:32 inigo_lerga Assigned To => inigo_lerga
2020-01-13 11:32 inigo_lerga OBNetwork customer => No
2020-01-13 11:32 inigo_lerga Modules => Core
2020-01-13 11:32 inigo_lerga Triggers an Emergency Pack => No
2020-01-13 11:33 inigo_lerga Status new => scheduled
2020-01-13 11:33 inigo_lerga Relationship added related to 0041287
2020-01-13 11:48 inigo_lerga Description Updated View Revisions
2020-01-13 12:11 inigo_lerga Note Added: 0116793
2020-01-17 14:17 hgbot Checkin
2020-01-17 14:17 hgbot Note Added: 0117025
2020-01-17 14:17 hgbot Status scheduled => resolved
2020-01-17 14:17 hgbot Resolution open => fixed
2020-01-17 14:17 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ca7c137a2054e2e68b6eb81816e47f5a4ba85e1a [^]
2020-01-17 14:17 hgbot Checkin
2020-01-17 14:17 hgbot Note Added: 0117026
2020-01-17 14:17 hgbot Checkin
2020-01-17 14:17 hgbot Note Added: 0117027
2020-01-17 14:18 dmiguelez Review Assigned To => dmiguelez
2020-01-17 14:18 dmiguelez Note Added: 0117028
2020-01-17 14:18 dmiguelez Status resolved => closed
2020-01-17 14:18 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker