Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042490
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajoralways2019-12-09 13:402020-09-04 07:23
ReporterfranciscoView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042490: Discount and Promtions with Coupon doesn't show a message is you apply a coupon out of date range

DescriptionIf you apply a coupon out of date range the POs does not show any message, it should warn about the coupon is not valid
Steps To ReproduceTested in retail_modules-psql_pi:

In backoffice go to Discount and promotions and select the promo 'Coupon 10' and set an expired date
 Starting date= 01/01/2014,
 Ending Date=31/12/2014

Go to POS
Go to menu Coupon code
enter 'Coupon10'
Insert the product 'AVALANCHE TRANSCEIVER'

The promo is not applied but it should show a message warning us that the dates for the coupon has expired
Proposed SolutionIt is difficult to fix the underlying problem in general, because only by executing the discounts engine we will know for sure if a discount can be applied or not.

However, we can at least add a basic filter in the remote request done to load a Coupon information, so that if the discount associated with it has an expiration date that doesn't comply with the current date, it can be immediately rejected at that point.

As part of this issue we will only fix this case. Other more complex cases (like discounts associated with specific customers or products) should be considered a feature request.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0122623)
hgbot (developer)
2020-09-04 04:51

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/3 [^]
(0122630)
hgbot (developer)
2020-09-04 07:23

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/3 [^]
(0122631)
hgbot (developer)
2020-09-04 07:23

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: cec7140682e3b197d6e2d767126c7189f7566748
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-09-03T07:56:54+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/cec7140682e3b197d6e2d767126c7189f7566748 [^]

Fixed ISSUE-42490: Added Date validation in Coupon Availability
* Added Discount Starting and Ending date validation when checking Coupon Availability

---
M src/org/openbravo/retail/discounts/coupons/CouponAvailability.java
---

- Issue History
Date Modified Username Field Change
2019-12-09 13:40 francisco New Issue
2019-12-09 13:40 francisco Assigned To => Retail
2019-12-09 13:40 francisco Triggers an Emergency Pack => No
2020-08-24 13:58 marvintm Proposed Solution updated
2020-08-24 13:58 marvintm Type feature request => defect
2020-08-24 13:58 marvintm Proposed Solution updated
2020-09-02 07:10 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-09-03 04:47 ranjith_qualiantech_com Status new => scheduled
2020-09-04 04:51 hgbot Note Added: 0122623
2020-09-04 07:23 hgbot Note Added: 0122630
2020-09-04 07:23 hgbot Resolution open => fixed
2020-09-04 07:23 hgbot Status scheduled => closed
2020-09-04 07:23 hgbot Note Added: 0122631

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker