Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0042430 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Advanced Warehouse Operations | minor | always | 2019-11-28 10:25 | 2019-12-12 23:01 | |||
| Reporter | dmiguelez | View Status | public | |||||
| Assigned To | dmiguelez | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | dmiguelez | |||||||
| Regression introduced in release | ||||||||
| Summary | 0042430: Improve performance in Task Generation Process and in Task Confirmation Process | |||||||
| Description | The performance is this two processes, Task Generation and Task Confirmation is acceptable for individual Tasks. However, when this processes are run by another process that calls them several times, it takes quite some time. It is possible to improve performance for both processes, Task Generation and Task Confirmation. | |||||||
| Steps To Reproduce | Reproduced in a client with a custom development that has a process that calls this flows many times. The time taken by this process is around 120 seconds. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0115931) hgbot (developer) 2019-11-28 11:13 |
Repository: erp/mods/org.openbravo.distributionorder Changeset: dc5b6850b16df6c2eb7c7ee4cec2fa741816eda9 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Thu Nov 28 11:13:45 2019 +0100 URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/dc5b6850b16df6c2eb7c7ee4cec2fa741816eda9 [^] Related to Issue 42430. Performance improvements * Moves the refresh of the movement out of the method, to do it only once when the calculations are finished * Change property navigation with hql query to avoid loading more information than necessary into the hibernate session and improve performance --- M src/org/openbravo/distributionorder/erpCommon/utility/DistributioOrderUtils.java --- |
|
(0115932) hgbot (developer) 2019-11-28 11:23 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 004de9677bbdef95974b499e463c340a9d22cd61 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Thu Nov 28 11:23:14 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/004de9677bbdef95974b499e463c340a9d22cd61 [^] Related to Issue 42430. Performance improvements * When a Task is defiened as auto-confirmed, before calling the confirmation process, clear the session of hibernate. To do this change it is necessary to send the batchOfTasksId as a parameter for some methods * In RoutingAssignment and WarehouseAssignment, us the productCategoryId from the taskRequirement object instead of navigating to the property of the product, which triggers a query to the db * In Utilities, when calling the movement_post and the inout_post methods remove the process and the pinstance objects from the hibernate session --- M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOrii_ReferencedInventoryImprovementBoxTest.java M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/AutoConfirmatorBehaveAsGroupTasks.java M src/org/openbravo/warehouse/advancedwarehouseoperations/task/InternalRoutingAssignmentUtils.java M src/org/openbravo/warehouse/advancedwarehouseoperations/task/WarehouseAlgorithmsUtils.java M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/Utilities.java --- |
|
(0115947) hgbot (developer) 2019-11-28 15:49 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders Changeset: eaaf61d295e8eabe629d79b0807fd8a30d63b94a Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Thu Nov 28 11:16:38 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/eaaf61d295e8eabe629d79b0807fd8a30d63b94a [^] Related to Issue 42430. Improve performance * Create a new static variable in the class to store the message from the Database instead of retrieving it every execution * A change has been done in Core in a Trigger to allow to update some columns of the movementline when it is already processed. With this change it is no longer necessary to disable/enable the triggers. --- M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/ittalgorithm/ReceiptOrIssueDistributionOrder_ITT.java M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/taskhook/IssueAndReceiptDistributionOrderPostConfirmTaskHook.java --- |
|
(0115948) hgbot (developer) 2019-11-28 15:49 |
Repository: erp/devel/pi Changeset: ebfdf075a6f7945c3beed432d6ae0eddd573870f Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Thu Nov 28 10:27:46 2019 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/ebfdf075a6f7945c3beed432d6ae0eddd573870f [^] Related to Issue 42430. Changed validation in Trigger The validation in the trigger did not allow to do any change to an already processed or posted inoutline. The change done is to allow to modify some columns and to control which ones can not be changed. For example, the updated column can be modified after this change even if the inoutline is already posted or processed. --- M src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml --- |
|
(0115949) dmiguelez (developer) 2019-11-28 15:51 |
Test plan: Tested in client and time was reduced from 120 to around 80 seconds for the full process. |
|
(0116145) dmiguelez (developer) 2019-12-09 11:07 |
Code Review + Testing Ok |
|
(0116291) hudsonbot (developer) 2019-12-12 23:01 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-11-28 10:25 | dmiguelez | New Issue | |
| 2019-11-28 10:25 | dmiguelez | Assigned To | => Triage Finance |
| 2019-11-28 11:13 | hgbot | Checkin | |
| 2019-11-28 11:13 | hgbot | Note Added: 0115931 | |
| 2019-11-28 11:23 | hgbot | Checkin | |
| 2019-11-28 11:23 | hgbot | Note Added: 0115932 | |
| 2019-11-28 15:49 | hgbot | Checkin | |
| 2019-11-28 15:49 | hgbot | Note Added: 0115947 | |
| 2019-11-28 15:49 | hgbot | Checkin | |
| 2019-11-28 15:49 | hgbot | Note Added: 0115948 | |
| 2019-11-28 15:50 | dmiguelez | Status | new => scheduled |
| 2019-11-28 15:50 | dmiguelez | Assigned To | Triage Finance => dmiguelez |
| 2019-11-28 15:50 | dmiguelez | Status | scheduled => resolved |
| 2019-11-28 15:50 | dmiguelez | Resolution | open => fixed |
| 2019-11-28 15:51 | dmiguelez | Note Added: 0115949 | |
| 2019-12-09 11:07 | dmiguelez | Review Assigned To | => dmiguelez |
| 2019-12-09 11:07 | dmiguelez | Note Added: 0116145 | |
| 2019-12-09 11:07 | dmiguelez | Status | resolved => closed |
| 2019-12-12 23:01 | hudsonbot | Checkin | |
| 2019-12-12 23:01 | hudsonbot | Note Added: 0116291 | |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |