Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041754
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformmajorhave not tried2019-09-04 12:152019-09-10 10:30
Reportersalvador_campanellaView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version3.0PR19Q3.1
StatusclosedFix in branchFixed in SCM revisionb3393dd2ea1e
ProjectionnoneETAnoneTarget Version3.0PR19Q3.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0PR19Q3SCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2019-04-26
Regression introduced in release3.0PR19Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/cbb150e17b8b69ad6f243c526ba64ef744ed8ba2 [^]
Triggers an Emergency PackNo
Summary

0041754: Negative values have string format when they are exported to csv file

DescriptionWhen the data of any grid is exported as csv using the button "Export to Spreadsheet" the negative values have a prefix "tabulation Character" this produces that the spreadsheet program format the field as text. This causes that these values don't be used to do autosum or in formulas.

Also, if the spreadsheet program has the tab character as separator the field with negative value have a shift to the right column

This prefix character was introduced in the issue
https://issues.openbravo.com/view.php?id=40647 [^]
Steps To Reproduce- Export any grid than contains negative values
- Open the CSV file with a spreadsheet program

a.- Leave the tab character selected as a separator
- Result all the values negatives will be a shift to the right column

b.- Deselect the tab character
- Do an Autosum with all the column that contains negative values
- Save the value
- Edit any negative value erasing the tab character
- Do the autosum again
- Result if different.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0041747pi closedalostale Negative values have string format when they are exported to csv file 

-  Notes
(0114406)
hgbot (developer)
2019-09-05 08:57

Repository: erp/backports/3.0PR19Q3.1
Changeset: b3393dd2ea1e145b2bf611a3ea6cf3b000e7665d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Sep 05 08:47:04 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3.1/rev/b3393dd2ea1e145b2bf611a3ea6cf3b000e7665d [^]

fixed bug 41754: negative numeric values exported as string in csv

  Whenever a value is exported to csv, it is prepended a tab if it starts with
  any character that can be used for formulas (issue 0040647) in order to prevent
  formula injection. This causes negative numeric values to be also escaped being
  treated as strings.

  Numeric values don't require to be escaped at all as they are cannot be crafted
  for formula injection.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0114487)
caristu (developer)
2019-09-10 10:30

Reviewed + tested OK.
(0114488)
caristu (developer)
2019-09-10 10:30

Reviewed + tested OK.

- Issue History
Date Modified Username Field Change
2019-09-05 08:32 alostale Type defect => backport
2019-09-05 08:32 alostale Target Version pi => 3.0PR19Q3.1
2019-09-05 08:57 hgbot Checkin
2019-09-05 08:57 hgbot Note Added: 0114406
2019-09-05 08:57 hgbot Status scheduled => resolved
2019-09-05 08:57 hgbot Resolution open => fixed
2019-09-05 08:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q3.1/rev/b3393dd2ea1e145b2bf611a3ea6cf3b000e7665d [^]
2019-09-10 10:30 caristu Note Added: 0114487
2019-09-10 10:30 caristu Status resolved => closed
2019-09-10 10:30 caristu Fixed in Version => 3.0PR19Q3.1
2019-09-10 10:30 caristu Note Added: 0114488


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker