0041752: Split lines is not distributing correctly the amounts

Description

When a line which contains manual discounts is split, the code which computes the resulting partial discounts does the following:

var amount = (clonedPromotion.amt / clonedPromotion.originalQty) * qty;

This is not correct for two reasons:
- It doesn't use the OB.DEC API, so it doesn't properly round amounts
- It doesn't adjust the resulting quantity, so in some cases it may happen that the resulting partial discounts do not sum the total amount of the original discount

Steps To Reproduce

Generate a line with amount 18.9, and quantity 3.
Add a manual for total amount 5 EUR
Split in two lines (quantities 2 and 1). Debug the previously mentioned code, and verify that resulting promotion amounts are not properly rounded.

Also, see tests SplitLineWithManualPromoDiscretionaryFixAmt and SplitLineWithManualPromoUserDefAmt

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0160481) shuehner (administrator) 2024-02-08 14:48	After mass reviewing old pos issues in 52891 => Closing as out of date

Issue History
Date Modified	Username	Field	Change
2019-09-04 19:36	marvintm	New Issue
2019-09-04 19:36	marvintm	Assigned To	=> jorge-garcia
2019-09-04 19:36	marvintm	Triggers an Emergency Pack	=> No
2024-02-08 14:48	shuehner	Note Added: 0160481
2024-02-08 14:48	shuehner	Status	new => closed
2024-02-08 14:48	shuehner	Resolution	open => out of date