Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041398
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Discounts and Promotionsmajoralways2019-07-17 16:412019-07-18 17:23
Reporterinaki_garciaView Statuspublic 
Assigned Toguilleaer 
PriorityimmediateResolutionfixedFixed in VersionRR19Q3
StatusclosedFix in branchFixed in SCM revisionfd3fa1ac8753
ProjectionnoneETAnoneTarget VersionRR19Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionmainSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041398: [19Q3] [D&P per hour] Discount or promotion can no longer be correctly created and used

DescriptionDue to the newly introduced "Discounts and Promotions per Hour" module extension, creating a discount or promotion in the usual workflow will lead to it not working. This is due to the newly added "Availability" section when creating a new discount or promotion, which has made it mandatory to have some of the the checkboxes checked in order to make the discount or promotion available for use when adding products to a ticket.

This issue is considered a regression, not because an error introduced in an existing project, but due to the disruption of the standard flow as a result of the introduction of this new functionality.
Steps To ReproducePRECONDITION: the "Discounts and Promotions per Hour" module must be installed alongside the standard "Discounts and Promotions" module

** Behaviour prior to the introduction of the module (19Q2 and earlier) **
-- Backend
0. Log in the ERP
1. Create a discount which isn't discretionary (p.e. "Price Adjustment" type) in the "Discounts and Promotions" window.
Fill all mandatory fields (highlighted in yellow), and add a Product by setting the "Included Products *" to "Only those defined"
and by creating a new record in the "Products" subtab

-- Frontend
0. Log in the Web POS as "vallblanca"
1. Add the product the discount has been created for
2. The discount is correctly added to the list item of the product



** Current behaviour **
- Execute steps 0 and 1 of Backend and Frontend
NOTICE that in step 2. of Frontend, the discount hasn't been correctly applied

-- Backend
2. Check the "All Week" checkbox in the availability section of the Discount, or check the current weekday and leave the Start/Ending Times blank

-- Frontend
- Execute steps 0 to 2 of Frontend
NOTICE that the discount is now correctly added

TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0041383 closedguilleaer [19Q3] [D&P per hour] Discount or promotion can no longer be correctly created and used 

-  Notes
(0113530)
hgbot (developer)
2019-07-18 17:03

Repository: erp/backports/3.0PR19Q3
Changeset: fd3fa1ac8753081b66039b225f1237c71492cad4
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jul 18 17:00:35 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/fd3fa1ac8753081b66039b225f1237c71492cad4 [^]

Fixed issue 41398: Discounts should be available all week by default

After add new feature to define discounts per hours, previous discounts present in the database must be marked as -allweek-. When the development was done developer tried to do it but forgot to define default in AD. Also is needed to set the column as required to update previous registers with Y

---
M src-db/database/model/tables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0113536)
jorge-garcia (developer)
2019-07-18 17:23

Code reviewed and tested

- Issue History
Date Modified Username Field Change
2019-07-18 16:41 guilleaer Type defect => backport
2019-07-18 16:41 guilleaer Target Version => RR19Q3
2019-07-18 16:41 guilleaer Assigned To Retail => guilleaer
2019-07-18 17:03 hgbot Checkin
2019-07-18 17:03 hgbot Note Added: 0113530
2019-07-18 17:03 hgbot Status scheduled => resolved
2019-07-18 17:03 hgbot Resolution open => fixed
2019-07-18 17:03 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/fd3fa1ac8753081b66039b225f1237c71492cad4 [^]
2019-07-18 17:23 jorge-garcia Review Assigned To => jorge-garcia
2019-07-18 17:23 jorge-garcia Note Added: 0113536
2019-07-18 17:23 jorge-garcia Status resolved => closed
2019-07-18 17:23 jorge-garcia Fixed in Version => RR19Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker