0041347: Incident on TPV with no payment method

Description

There is an issue in 19Q2 environment for TPV with layaways. Despite they don't have any payment method still they show the exact payment button, however, once you click on the checkmark button it outputs a JS error.

The error has been reproduced in Livebuilds (See attachments)

Steps To Reproduce

In touch point type window "Layaway orders" must be marked. (Attachment Livebuilds_001.png)

The Touch Point must not have any method of payment (Attachment Livebuilds_002.png)

Create a layaway and check if the green "Checkmark" button is available (Attachment Livebuilds_003.png)

Clicking on the "Checkmark" button will show the error: "Can not read properly..." (Attachment Livebuilds_004.png)

Proposed Solution

Please find attached a solution that hides the button when there is no payment method available.

Tags

No tags attached.

Attached Files

layawayfix.diff [^] (600 bytes) 2019-07-13 05:26 [Show Content] [Hide Content]

diff -r a9a66e06731a web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Thu May 09 13:00:33 2019 +0000
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Fri Jul 12 19:59:19 2019 -0300
@@ -744,6 +744,9 @@
         if (!OB.MobileApp.model.get('terminal').terminalType.calculateprepayments) {
           this.$.exactbutton.show();
         }
+      } else {
+        this.$.exactbutton.hide();
+        this.$.prepaymentsbuttons.hide();
       }
       this.updateLayawayAction();
     }

livebuilds_001.png [^] (157,384 bytes) 2019-07-13 05:27

livebuilds_002.png [^] (135,580 bytes) 2019-07-13 05:28

livebuilds_003.png [^] (125,063 bytes) 2019-07-13 05:28

livebuilds_004.png [^] (298,855 bytes) 2019-07-13 05:28

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2019-07-13 05:26	lbressan	New Issue
2019-07-13 05:26	lbressan	Assigned To	=> adrianromero
2019-07-13 05:26	lbressan	File Added: layawayfix.diff
2019-07-13 05:27	lbressan	File Added: livebuilds_001.png
2019-07-13 05:28	lbressan	File Added: livebuilds_002.png
2019-07-13 05:28	lbressan	File Added: livebuilds_003.png
2019-07-13 05:28	lbressan	File Added: livebuilds_004.png
2020-04-14 15:08	marvintm	Project	Java Client POS => Retail Modules
2020-04-14 15:09	marvintm	Triggers an Emergency Pack	=> No
2020-04-14 15:09	marvintm	Category	01 - General => Web POS
2022-03-03 14:19	adrianromero	Assigned To	adrianromero => Retail
2024-06-17 08:37	guillermogil	Assigned To	Retail => Triage Platform Conn
2024-06-18 10:30	adrianromero	Assigned To	Triage Platform Conn => adrianromero
2024-06-18 10:31	adrianromero	Assigned To	adrianromero => Retail