Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0041283 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Localization Pack: Spain] AEAT 390 | minor | have not tried | 2019-07-04 13:59 | 2019-09-10 17:31 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | collazoandy4 | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 530fdf287beb | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | Sandrahuguet | |||||||
| Regression introduced in release | ||||||||
| Summary | 0041283: eclipse warning: Unlikely argument type for equals(): EpigraphIAEOrgInfo seems to be unrelated to String | |||||||
| Description | The code is comparing a EpigraphIAEOrgInfo bob object to a String. While that technically compares getIdentifier (see BaseOBObject.toString) to a String that looks accidental especially given the identifier column definition of the table: obpi_pg=# select columnname from ad_column where ad_table_id = 'F468CC15B7B44F17AA68DA4D42E754CF' and isidentifier = 'Y'; columnname ------------------- Epiae_Epigraph_ID AD_Org_ID | |||||||
| Steps To Reproduce | [java] 10. INFO in /srv/ci/workspace/mod-simple-ci23.18102/modules/org.openbravo.module.aeat390.es/src/org/openbravo/module/aeat390/es/report/AEAT390Report2011.java (at line 174) [java] if ("N".equals(activity) && i <= 5) { [java] ^^^^^^^^ [java] Unlikely argument type for equals(): EpigraphIAEOrgInfo seems to be unrelated to String [java] ---------- [java] ---------- [java] 11. INFO in /srv/ci/workspace/mod-simple-ci23.18102/modules/org.openbravo.module.aeat390.es/src/org/openbravo/module/aeat390/es/v2012/report/AEAT390Report2012.java (at line 179) [java] if ("N".equals(activity) && i <= 5) { [java] ^^^^^^^^ [java] Unlikely argument type for equals(): EpigraphIAEOrgInfo seems to be unrelated to String | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0114509) hgbot (developer) 2019-09-10 17:31 |
Repository: erp/pmods/org.openbravo.module.aeat390.es Changeset: 5dfa197c4d50bcbc1203ab9d106ca68f0c66e764 Author: Armaignac <collazoandy4 <at> gmail.com> Date: Mon Aug 05 14:52:39 2019 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/5dfa197c4d50bcbc1203ab9d106ca68f0c66e764 [^] Related to issue 41283: eclipse warning: Unlikely argument type for equals(): EpigraphIAEOrgInfo seems to be unrelated to String Format source code to new eclipse build-int format --- M src/org/openbravo/module/aeat390/es/api/cashvat/AEAT390CashVATReadyCalculationsHelper.java M src/org/openbravo/module/aeat390/es/report/AEAT390Report2011.java M src/org/openbravo/module/aeat390/es/report/helper/AEAT390CalculationsHelper.java M src/org/openbravo/module/aeat390/es/v2012/report/AEAT390Report2012.java --- |
|
(0114510) hgbot (developer) 2019-09-10 17:31 |
Repository: erp/pmods/org.openbravo.module.aeat390.es Changeset: 530fdf287bebc450a5864718ebfe2707a8769ab6 Author: Armaignac <collazoandy4 <at> gmail.com> Date: Mon Aug 05 15:44:22 2019 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/530fdf287bebc450a5864718ebfe2707a8769ab6 [^] Fixes issue 41283: eclipse warning: Unlikely argument type for equals(): EpigraphIAEOrgInfo seems to be unrelated to String Removed eclipse warning in java 11 --- M src/org/openbravo/module/aeat390/es/api/cashvat/AEAT390CashVATReadyCalculationsHelper.java M src/org/openbravo/module/aeat390/es/report/AEAT390Report2011.java M src/org/openbravo/module/aeat390/es/report/helper/AEAT390CalculationsHelper.java M src/org/openbravo/module/aeat390/es/v2012/report/AEAT390Report2012.java --- |
|
(0114511) Sandrahuguet (developer) 2019-09-10 17:31 |
code review + testing ok |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-07-04 13:59 | shuehner | New Issue | |
| 2019-07-04 13:59 | shuehner | Assigned To | => Opentix-Test |
| 2019-08-02 14:37 | Sandrahuguet | Assigned To | Opentix-Test => collazoandy4 |
| 2019-08-02 19:35 | collazoandy4 | Status | new => scheduled |
| 2019-09-10 17:31 | hgbot | Checkin | |
| 2019-09-10 17:31 | hgbot | Note Added: 0114509 | |
| 2019-09-10 17:31 | hgbot | Checkin | |
| 2019-09-10 17:31 | hgbot | Note Added: 0114510 | |
| 2019-09-10 17:31 | hgbot | Status | scheduled => resolved |
| 2019-09-10 17:31 | hgbot | Resolution | open => fixed |
| 2019-09-10 17:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/530fdf287bebc450a5864718ebfe2707a8769ab6 [^] |
| 2019-09-10 17:31 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
| 2019-09-10 17:31 | Sandrahuguet | Note Added: 0114511 | |
| 2019-09-10 17:31 | Sandrahuguet | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |