Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041268
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2019-07-01 09:582019-08-06 16:12
ReporteraaroncaleroView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR19Q2.2
StatusclosedFix in branchFixed in SCM revisionb963e8c9401e
ProjectionnoneETAnoneTarget VersionRR19Q2.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041268: OB.UTIL.clone always copies arrays by reference

DescriptionOB.UTIL.clone always copies arrays by reference, instead of generating a new array and cloning the values.
Steps To ReproduceCheck the code that copies array properties:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/web/org.openbravo.mobile.core/source/utils/ob-utilities.js#l1057 [^]

Instead of checking if the property is an array, the code is checking if the whole object is an array, which is wrong
Proposed SolutionIn the linked code, change from
} else if (_.isArray(source)) {
to
} else if (_.isArray(source.get(key))) {
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0041207 closedranjith_qualiantech_com OB.UTIL.clone always copies arrays by reference 

-  Notes
(0113558)
hgbot (developer)
2019-07-22 12:07

 Repository: retail/backports/3.0RR19Q2.2/org.openbravo.retail.posterminal
Changeset: 3890477c3f2cabb3c889c814b0fa5e361e8dd843
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jul 22 15:36:26 2019 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR19Q2.2/org.openbravo.retail.posterminal/rev/3890477c3f2cabb3c889c814b0fa5e361e8dd843 [^]

Related to issue 41268 : Shipping Address should be same as invoice address when loading paid receipt

* When splitting lines with promotions, line lineQtyOffer should be updated instead of creating new lines to apply promotions

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0113559)
hgbot (developer)
2019-07-22 12:08

 Repository: retail/backports/3.0RR19Q2.2/org.openbravo.mobile.core
Changeset: f9e72aad8cd3304fe8823775c85093867fc384f5
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jul 22 15:36:28 2019 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR19Q2.2/org.openbravo.mobile.core/rev/f9e72aad8cd3304fe8823775c85093867fc384f5 [^]

Related to issue 41268 : Update OB.UTIL.clone to check the property is an Array

* When cloning object from array, if object is backbone the it should cloned recursively
  if object is not backbone, then copy of object should be pushed to target object

---
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---

- Issue History
Date Modified Username Field Change
2019-07-03 19:04 marvintm Type defect => backport
2019-07-03 19:04 marvintm Target Version => RR19Q2.2
2019-07-22 12:07 hgbot Checkin
2019-07-22 12:07 hgbot Note Added: 0113558
2019-07-22 12:08 hgbot Checkin
2019-07-22 12:08 hgbot Note Added: 0113559
2019-07-22 12:09 ranjith_qualiantech_com Status scheduled => resolved
2019-07-22 12:09 ranjith_qualiantech_com Resolution open => fixed
2019-08-06 16:12 marvintm Review Assigned To => marvintm
2019-08-06 16:12 marvintm Status resolved => closed
2019-08-06 16:12 marvintm Fixed in Version => RR19Q2.2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker