0041254: ReportProjectProfitabilityJR.noConversionToHours is not using bind-params

Description

This code is not using bind-params:

    if (StringUtils.isNotEmpty(strOrg)) {
      hsqlScript.append(" and p." + Project.PROPERTY_ORGANIZATION + ".id in (" + strOrg + ")");
    }

When fixing please apply new HQL-style to every HQL in this file.

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0041253

3.0PR19Q4

closed

AtulOpenbravo

ReportProjectProfitabilityJR.noConversionToHours is not using bind-params

Notes
(0113472) hgbot (developer) 2019-07-17 11:26	Repository: erp/backports/3.0PR19Q3 Changeset: eb79d76b3f7dba6b593397532aaf3ca976ec034d Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Mon Jul 15 18:17:44 2019 +0530 URL: http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/eb79d76b3f7dba6b593397532aaf3ca976ec034d [^] Fixes Issue 41254: ReportProjectProfitabilityJR.noConversionToHours is not using bind-params Applied bind-params to organization ids in noConversionToHours method. Organization ids are obtained from OrganizationStructureProvider --- M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java ---

(0113476) dmiguelez (viewer) 2019-07-17 11:28	Code Review + Testing Ok

Issue History
Date Modified	Username	Field	Change
2019-07-03 16:53	shuehner	Type	defect => backport
2019-07-03 16:53	shuehner	Target Version	=> 3.0PR19Q3
2019-07-17 11:26	hgbot	Checkin
2019-07-17 11:26	hgbot	Note Added: 0113472
2019-07-17 11:26	hgbot	Status	scheduled => resolved
2019-07-17 11:26	hgbot	Resolution	open => fixed
2019-07-17 11:26	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/eb79d76b3f7dba6b593397532aaf3ca976ec034d [^]
2019-07-17 11:28	dmiguelez	Review Assigned To	=> dmiguelez
2019-07-17 11:28	dmiguelez	Note Added: 0113476
2019-07-17 11:28	dmiguelez	Status	resolved => closed
2019-07-17 11:28	dmiguelez	Fixed in Version	=> 3.0PR19Q3