Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041252
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminorhave not tried2019-07-03 16:482019-08-28 18:52
ReportershuehnerView Statuspublic 
Assigned Tocollazoandy4 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q4
StatusclosedFix in branchFixed in SCM revisionbfc248a387dd
ProjectionnoneETAnoneTarget Version3.0PR19Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041252: ReportGeneralLedgerJournal.getDocuments is not using bind-params

DescriptionThis function is not using bind-parameters for 2 Organization id's lists here:

      whereClause.append(DocumentType.PROPERTY_ORGANIZATION + ".id");
      whereClause.append(" in (" + Utility.getInStrSet(orgStrct) + ")");
      whereClause.append(" and ca." + AcctSchemaTable.PROPERTY_ORGANIZATION + ".id");
      whereClause.append(" in (" + Utility.getInStrSet(orgStrct) + ")");
      whereClause.append(" order by cd." + DocumentType.PROPERTY_DOCUMENTCATEGORY);

When fixing please apply new HQL-style to every HQL in this file.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0041452 closedcollazoandy4 Apply HQL style guide to ReportGeneralLedgerJournal 
related to defect 0041711 closedcollazoandy4 Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params 
blocks design defect 0038136 acknowledgedTriage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 

-  Notes
(0113642)
collazoandy4 (viewer)
2019-07-24 23:10

 Test Plan
  Go to Journal Entries Report and set:
    Organization: Region Norte
    General Ledger: F&B España
    From: 01-07-2018
    To: 24-07-2019
    From Account: (43000) Clientes (euros) a corto plazo
    To Account: (47700) Hacienda Pública IVA repercutido
    Document: AR Invoice
    DocumentNo: 1000259
  Clic on Search button and check the process ends without error
(0114296)
hgbot (developer)
2019-08-28 13:56

 Repository: erp/devel/pi
Changeset: bfc248a387dd81a10b36ed9f06c7a524268760ce
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Jul 24 17:07:08 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/bfc248a387dd81a10b36ed9f06c7a524268760ce [^]

Fixes issue 41252:ReportGeneralLedgerJournal.getDocuments is not using
bind-params

Added missing bind-params

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
---
(0114297)
Sandrahuguet (viewer)
2019-08-28 13:58

 code review + testing ok
(0114306)
hudsonbot (viewer)
2019-08-28 18:52

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/236aa85fbe33 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2019-07-03 16:48 shuehner New Issue
2019-07-03 16:48 shuehner Assigned To => Triage Finance
2019-07-03 16:48 shuehner OBNetwork customer => No
2019-07-03 16:48 shuehner Modules => Core
2019-07-03 16:48 shuehner Triggers an Emergency Pack => No
2019-07-03 16:49 shuehner Relationship added blocks 0038136
2019-07-03 16:51 shuehner Description Updated View Revisions
2019-07-04 12:16 shuehner Target Version => 3.0PR19Q4
2019-07-24 19:43 collazoandy4 Assigned To Triage Finance => collazoandy4
2019-07-24 19:43 collazoandy4 Status new => scheduled
2019-07-24 23:10 collazoandy4 Note Added: 0113642
2019-08-28 10:20 Sandrahuguet Relationship added related to 0041452
2019-08-28 13:56 hgbot Checkin
2019-08-28 13:56 hgbot Note Added: 0114296
2019-08-28 13:56 hgbot Status scheduled => resolved
2019-08-28 13:56 hgbot Resolution open => fixed
2019-08-28 13:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bfc248a387dd81a10b36ed9f06c7a524268760ce [^]
2019-08-28 13:58 Sandrahuguet Review Assigned To => Sandrahuguet
2019-08-28 13:58 Sandrahuguet Note Added: 0114297
2019-08-28 13:58 Sandrahuguet Status resolved => closed
2019-08-28 13:58 Sandrahuguet Fixed in Version => 3.0PR19Q4
2019-08-28 14:01 Sandrahuguet Relationship added related to 0041711
2019-08-28 18:52 hudsonbot Checkin
2019-08-28 18:52 hudsonbot Note Added: 0114306

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker