Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041248
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 00. Application dictionarymajorhave not tried2019-07-02 16:012019-07-05 18:36
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q3
StatusclosedFix in branchFixed in SCM revisionaeeeea906d04
ProjectionnoneETAnoneTarget Version3.0PR19Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041248: ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params

DescriptionThose functions are not using bind-params.


when fixing please apply new HQL-style to all 3 HQL's in the file
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 00412393.0PR19Q4 closedalostale ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params 

-  Notes
(0113197)
hgbot (developer)
2019-07-05 10:45

 Repository: erp/backports/3.0PR19Q3
Changeset: b7e512b8145c7dc229bc49e9a4ee3d7cc1bab81e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 03 13:55:29 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/b7e512b8145c7dc229bc49e9a4ee3d7cc1bab81e [^]

related to issue 41248: HQL style in ADTreeDatasourceService

  Don't use StringBuilder for String concatenation
  Some other small changes

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
---
(0113198)
hgbot (developer)
2019-07-05 10:45

 Repository: erp/backports/3.0PR19Q3
Changeset: aeeeea906d0428b90a560ebd1bbbbd1f33695672
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 03 15:38:10 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/aeeeea906d0428b90a560ebd1bbbbd1f33695672 [^]

fixed bug 41248: use bind parameters in ADTreeDatasourceService

  * Use parameter in query in getNodeChildrenQuery method where possible
  * Do not use deprecated OBDal.getReadableOrganizationsInClause method
  * Properly escape paremeter values in clasues coming from AD

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
---
(0113207)
caristu (developer)
2019-07-05 18:36

 Reviewed

- Issue History
Date Modified Username Field Change
2019-07-03 15:26 alostale Type defect => backport
2019-07-03 15:26 alostale Target Version => 3.0PR19Q3
2019-07-05 10:45 hgbot Checkin
2019-07-05 10:45 hgbot Note Added: 0113197
2019-07-05 10:45 hgbot Checkin
2019-07-05 10:45 hgbot Note Added: 0113198
2019-07-05 10:45 hgbot Status scheduled => resolved
2019-07-05 10:45 hgbot Resolution open => fixed
2019-07-05 10:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/aeeeea906d0428b90a560ebd1bbbbd1f33695672 [^]
2019-07-05 18:36 caristu Assigned To platform => alostale
2019-07-05 18:36 caristu Note Added: 0113207
2019-07-05 18:36 caristu Status resolved => closed
2019-07-05 18:36 caristu Fixed in Version => 3.0PR19Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker