Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0041191 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Localization Pack: Spain] AEAT 340 | trivial | have not tried | 2019-06-27 12:03 | 2019-07-02 11:44 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | aaf8c6a43072 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | vmromanos | |||||||
| Regression introduced in release | ||||||||
| Summary | 0041191: Remove the old, unused, no longer useful junit tests | |||||||
| Description | This module contains 3 junit tests still extending the long deprecated BaseTest class. Checking on the tests; - their build.xml to run it does not work - The unit tests have not been run a long time - checking with VMA they are no longer useful to keep | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Remove the nit-tests + the build.xml in the module which only exists to run those from commandline. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0113051) hgbot (developer) 2019-06-27 12:33 |
Repository: erp/pmods/org.openbravo.module.aeat340.es Changeset: 35e084c299890ddbb8e94d631acf0b07b38f5c1d Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Thu Jun 27 12:33:34 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/35e084c299890ddbb8e94d631acf0b07b38f5c1d [^] Fixed 41191. Remove old obsolete junit tests. - build.xml was only to run those from commandline - Test used deprecated BaseTest from pi - never used a long time - not useful to keep around --- R build.xml R src-test/org/openbravo/test/AEAT340NumericAmountTest.java R src-test/org/openbravo/test/AEAT340NumericTaxRateTest.java R src-test/org/openbravo/test/AEAT340UtilityTest.java --- |
|
(0113058) vmromanos (manager) 2019-06-27 15:22 |
Code review OK |
|
(0113137) hgbot (developer) 2019-07-02 11:43 |
Repository: erp/pmods/org.openbravo.module.aeat340.es Changeset: aaf8c6a43072aae679b21cf02b425422ee5a5a56 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Thu Jun 27 12:33:34 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/aaf8c6a43072aae679b21cf02b425422ee5a5a56 [^] Fixed 41191. Remove old obsolete junit tests. - build.xml was only to run those from commandline - Test used deprecated BaseTest from pi - never used a long time - not useful to keep around --- R build.xml R src-test/org/openbravo/test/AEAT340NumericAmountTest.java R src-test/org/openbravo/test/AEAT340NumericTaxRateTest.java R src-test/org/openbravo/test/AEAT340UtilityTest.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-06-27 12:03 | shuehner | New Issue | |
| 2019-06-27 12:03 | shuehner | Assigned To | => shuehner |
| 2019-06-27 12:03 | shuehner | Relationship added | related to 0041188 |
| 2019-06-27 12:33 | hgbot | Checkin | |
| 2019-06-27 12:33 | hgbot | Note Added: 0113051 | |
| 2019-06-27 12:33 | hgbot | Status | new => resolved |
| 2019-06-27 12:33 | hgbot | Resolution | open => fixed |
| 2019-06-27 12:33 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/35e084c299890ddbb8e94d631acf0b07b38f5c1d [^] |
| 2019-06-27 15:22 | vmromanos | Review Assigned To | => vmromanos |
| 2019-06-27 15:22 | vmromanos | Note Added: 0113058 | |
| 2019-06-27 15:22 | vmromanos | Status | resolved => closed |
| 2019-07-02 11:43 | hgbot | Checkin | |
| 2019-07-02 11:43 | hgbot | Note Added: 0113137 | |
| 2019-07-02 11:43 | hgbot | Status | closed => resolved |
| 2019-07-02 11:43 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/35e084c299890ddbb8e94d631acf0b07b38f5c1d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/aaf8c6a43072aae679b21cf02b425422ee5a5a56 [^] |
| 2019-07-02 11:44 | vmromanos | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |