Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041190
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Localization Pack: Spain] AEAT 303trivialhave not tried2019-06-27 11:492019-06-27 15:22
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision1ccb9a98f335
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Regression introduced in release
Summary

0041190: Remove the old, unused, no longer useful junit tests

DescriptionThis module contains 3 junit tests still extending the long deprecated BaseTest class.

Checking on the tests;
- their build.xml to run it does not work
- The unit tests have not been run a long time
- checking with VMA they are no longer useful to keep
Steps To Reproduce-
Proposed SolutionRemove the unit-tests + the build.xml in the module which only exists to run those from commandline.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041188 closedshuehner Remove the old, unused, no longer useful junit tests 

-  Notes
(0113050)
hgbot (developer)
2019-06-27 11:51

Repository: erp/pmods/org.openbravo.module.aeat303.es
Changeset: 1ccb9a98f335e5f2e180123bb3ecf96bf2b6e9aa
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 27 11:50:57 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat303.es/rev/1ccb9a98f335e5f2e180123bb3ecf96bf2b6e9aa [^]

Fixed 41190. Remove old obsolete junit tests.

- build.xml was only to run those from commandline
- Test used deprecated BaseTest from pi
  - never used a long time
  - not useful to keep around

---
R build.xml
R src-test/org/openbravo/test/AEAT303NumericAmountTest.java
R src-test/org/openbravo/test/AEAT303UtilityTest.java
R src-test/org/openbravo/test/AEAT303VATLine.java
---
(0113057)
vmromanos (manager)
2019-06-27 15:22

Code review OK

- Issue History
Date Modified Username Field Change
2019-06-27 11:49 shuehner New Issue
2019-06-27 11:49 shuehner Assigned To => shuehner
2019-06-27 11:50 shuehner Relationship added related to 0041188
2019-06-27 11:50 shuehner Type defect => feature request
2019-06-27 11:51 hgbot Checkin
2019-06-27 11:51 hgbot Note Added: 0113050
2019-06-27 11:51 hgbot Status new => resolved
2019-06-27 11:51 hgbot Resolution open => fixed
2019-06-27 11:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat303.es/rev/1ccb9a98f335e5f2e180123bb3ecf96bf2b6e9aa [^]
2019-06-27 15:22 vmromanos Review Assigned To => vmromanos
2019-06-27 15:22 vmromanos Note Added: 0113057
2019-06-27 15:22 vmromanos Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker