Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041094
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2019-06-14 09:242019-06-21 14:14
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PriorityhighResolutionfixedFixed in Version3.0PR19Q3
StatusclosedFix in branchFixed in SCM revisiona56212b85ebd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041094: Javascript formatting scripts fails on MacOSX

Descriptionjslint/jsformatter execution fails when executed in OSX. According to the provided screenshot, it is related to an argument using '--' in xargs.
Steps To ReproduceRun jslint, jsformatter or commit using the provided mercurial hooks on an OSX machine
Proposed SolutionThe syntax of some commands are slightly different between Linux/OSX. Change it and check it works on both machines
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2019-06-14 09-23-39.png [^] (337,033 bytes) 2019-06-14 09:24

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0039983 closedjarmendariz Upgrade javascript linter and formatter 

-  Notes
(0112809)
hgbot (developer)
2019-06-17 11:37

 Repository: erp/devel/pi
Changeset: a56212b85ebdfd89cf1a8b6e8509c9f832c1a9c8
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jun 14 09:26:03 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a56212b85ebdfd89cf1a8b6e8509c9f832c1a9c8 [^]

Fixed issue 41094: Improved support for OSX

There are parts of the script that, although correct in linux, uses
options that are not supported on OSX:
* xargs --max-args is not present on OSX, replaced by -n
* find -printf is not present on BSD/OSX, for our purpose it can be
replaced by executing dirname

---
M modules/org.openbravo.client.kernel/jsformatter/jsformatter
M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg-hook
M modules/org.openbravo.client.kernel/jslint/jslint
M modules/org.openbravo.client.kernel/jslint/jslint-hg-hook
M modules/org.openbravo.client.kernel/jsutils/dir-functions
---
(0112839)
hudsonbot (developer)
2019-06-17 19:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2ad95dac1570 [^]
Maturity status: Test
(0112943)
caristu (developer)
2019-06-21 14:14

 Reviewed

- Issue History
Date Modified Username Field Change
2019-06-14 09:24 jarmendariz New Issue
2019-06-14 09:24 jarmendariz Assigned To => jarmendariz
2019-06-14 09:24 jarmendariz File Added: Screenshot from 2019-06-14 09-23-39.png
2019-06-14 09:24 jarmendariz Modules => Core
2019-06-14 09:24 jarmendariz Triggers an Emergency Pack => No
2019-06-14 09:25 jarmendariz Relationship added caused by 0039983
2019-06-14 09:25 jarmendariz Status new => scheduled
2019-06-17 11:37 hgbot Checkin
2019-06-17 11:37 hgbot Note Added: 0112809
2019-06-17 11:37 hgbot Status scheduled => resolved
2019-06-17 11:37 hgbot Resolution open => fixed
2019-06-17 11:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a56212b85ebdfd89cf1a8b6e8509c9f832c1a9c8 [^]
2019-06-17 11:42 jarmendariz Review Assigned To => caristu
2019-06-17 19:39 hudsonbot Checkin
2019-06-17 19:39 hudsonbot Note Added: 0112839
2019-06-21 14:14 caristu Note Added: 0112943
2019-06-21 14:14 caristu Status resolved => closed
2019-06-21 14:14 caristu Fixed in Version => 3.0PR19Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker