Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041033
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2019-06-05 16:432019-06-07 08:19
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in Version3.0PR19Q3
StatusclosedFix in branchFixed in SCM revisionaebfddd2027d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2019-01-08
Regression introduced in release3.0PR19Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/90c48060859cc70935add00e77e8065dedb197cc [^]
Triggers an Emergency PackNo
Summary

0041033: ImportEntryPreProcessors with qualifiers are not executed

DescriptionImportEntryPreProcessors with qualifiers are not executed
Steps To Reproduce1) Apply the attached patch, it contains a test case that assumes thatImportEntryPreProcessors are executed
 
2) Run the test. It fails. Note that the TestImportEntryPreProcessor is not executed.

3) Remove the Qualifier annotation from the TestImportEntryPreProcessor class and rerun the test. Note that now it works.
TagsNo tags attached.
Attached Filesdiff file icon 41033_test_case.diff [^] (2,982 bytes) 2019-06-05 16:43 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 00342283.0PR17Q1 closedmtaal Add getInstances method to WeldUtils class 
depends on backport 00410343.0PR19Q2.1 closedcaristu ImportEntryPreProcessors with qualifiers are not executed 
caused by feature request 0039878 closedjarmendariz Import Entry can be created defining Client and Organization 
related to defect 0041035 closedcaristu ImportEntryPreProcessor should be declared as abstract 

-  Notes
(0112456)
hgbot (developer)
2019-06-06 11:00

Repository: erp/devel/pi
Changeset: aebfddd2027d4005ee1eba6e753c21f608e7a7c3
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 06 10:34:38 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/aebfddd2027d4005ee1eba6e753c21f608e7a7c3 [^]

fixes bug 41033: ImportEntryPreProcessors with qualifiers are not executed

  As part of the refactor to provide the ImportEntryBuilder[1], the injection of the import entry preprocessors was changed. As the instances of that class are created outside of the Weld scope, the preprocessors are injected using "WeldUtils.getInstances()" method instead of using @Inject.

  The problem here is that "WeldUtils.getInstances()" looked for all beans of an specific type that does not have a qualifier. For this reason, import entry preprocessors with qualifiers were not being found and, therefore, not executed by the ImportEntryBuilder before creating the import entry.

  To fix this problem now "WeldUtils.getInstances()" has been changed in order to look for any bean of a particular type (regardless of whether it is qualified or not). This is done by specifying the @Any qualifier to the "BeanManager.getBeans()" method.

  Thus, now WeldUtils.getInstances() behaves exactly in the same way as when using @Inject together with @Any when we are inside the scope of Weld.

 [1] https://code.openbravo.com/erp/devel/pi/rev/90c48060859cc70935add00e77e8065dedb197cc [^]

---
M modules/org.openbravo.base.weld/src/org/openbravo/base/weld/WeldUtils.java
---
(0112457)
hgbot (developer)
2019-06-06 11:00

Repository: erp/devel/pi
Changeset: 3f43ae2410c8e36db61217f746616d5045dca3a9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 06 10:58:49 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3f43ae2410c8e36db61217f746616d5045dca3a9 [^]

related to issue 41033: code improvements

  - Use Any AnnotationLiteral (available since CDI 2.0)
  - Use diamond operator
  - Remove unused injection of ImportEntryPreProcessor in the ImportEntryManager (they are used in the ImportEntryBuilder)

---
M modules/org.openbravo.base.weld/src/org/openbravo/base/weld/WeldUtils.java
M src/org/openbravo/service/importprocess/ImportEntryManager.java
---
(0112458)
hgbot (developer)
2019-06-06 11:00

Repository: erp/devel/pi
Changeset: 7148f9e42956ca46a0aabeecdfca2b12dbc4eef5
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 06 10:59:01 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7148f9e42956ca46a0aabeecdfca2b12dbc4eef5 [^]

related to issue 41033: add test cases

---
M modules/org.openbravo.base.weld/src-test/org/openbravo/base/weld/test/testinfrastructure/CdiInfrastructure.java
---
(0112459)
hgbot (developer)
2019-06-06 11:02

Repository: erp/devel/pi
Changeset: 6061bd189bd12a403c6831b59a6f55cd91b8f395
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 06 11:01:58 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6061bd189bd12a403c6831b59a6f55cd91b8f395 [^]

related to issue 41033: add missing test classes

---
A modules/org.openbravo.base.weld/src-test/org/openbravo/base/weld/test/testinfrastructure/ExtensionBean.java
A modules/org.openbravo.base.weld/src-test/org/openbravo/base/weld/test/testinfrastructure/QualifiedBean.java
A modules/org.openbravo.base.weld/src-test/org/openbravo/base/weld/test/testinfrastructure/UnqualifiedBean.java
---
(0112460)
hgbot (developer)
2019-06-06 11:03

Repository: erp/devel/pi
Changeset: 2db86bead3d4680eefc1789981c5d53ba85563dd
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 06 11:03:21 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2db86bead3d4680eefc1789981c5d53ba85563dd [^]

related to issue 41033: fix javadoc wrong text

---
M modules/org.openbravo.base.weld/src-test/org/openbravo/base/weld/test/testinfrastructure/UnqualifiedBean.java
---
(0112463)
hgbot (developer)
2019-06-06 11:24

Repository: erp/devel/pi
Changeset: e7f7f338f322bebafba71bf16aacbb2166f476ff
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 06 11:24:08 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e7f7f338f322bebafba71bf16aacbb2166f476ff [^]

related to issue 41033: avoid API change

---
M modules/org.openbravo.base.weld/src/org/openbravo/base/weld/WeldUtils.java
---
(0112465)
hgbot (developer)
2019-06-06 11:44

Repository: erp/devel/pi
Changeset: 41c47dd2afae26b76735c2e73f1fd5235a4b82df
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 06 11:42:41 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/41c47dd2afae26b76735c2e73f1fd5235a4b82df [^]

related to issue 41033: change assertion to fix error in CI

---
M modules/org.openbravo.base.weld/src-test/org/openbravo/base/weld/test/testinfrastructure/CdiInfrastructure.java
---
(0112471)
hgbot (developer)
2019-06-06 12:42

Repository: erp/devel/pi
Changeset: 06711d4d7d57a6ebb95446bf2428a4a3118d8e4a
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 06 12:41:37 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/06711d4d7d57a6ebb95446bf2428a4a3118d8e4a [^]

related to issue 41033: use CoreMatchers.allOf instead of Matchers.allOf

  Test was not compiling in JDK10+ due to some problem related with generics and "Matchers.allOf". Using "CoreMatchers.allOf" instead.

---
M modules/org.openbravo.base.weld/src-test/org/openbravo/base/weld/test/testinfrastructure/CdiInfrastructure.java
---
(0112473)
hgbot (developer)
2019-06-06 13:22

Repository: erp/devel/pi
Changeset: 4239ab3ce79e7d9e54962beb8fe37febfc208407
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 06 13:22:12 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4239ab3ce79e7d9e54962beb8fe37febfc208407 [^]

related to issue 41033: change assertion

  The test compilation was still failing in CI, changing the assertion to avoid the problem

---
M modules/org.openbravo.base.weld/src-test/org/openbravo/base/weld/test/testinfrastructure/CdiInfrastructure.java
---
(0112475)
hudsonbot (developer)
2019-06-06 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5f04242085fd [^]
Maturity status: Test
(0112476)
hudsonbot (developer)
2019-06-06 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5f04242085fd [^]
Maturity status: Test
(0112477)
hudsonbot (developer)
2019-06-06 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5f04242085fd [^]
Maturity status: Test
(0112478)
hudsonbot (developer)
2019-06-06 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5f04242085fd [^]
Maturity status: Test
(0112479)
hudsonbot (developer)
2019-06-06 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5f04242085fd [^]
Maturity status: Test
(0112480)
hudsonbot (developer)
2019-06-06 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5f04242085fd [^]
Maturity status: Test
(0112481)
hudsonbot (developer)
2019-06-06 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5f04242085fd [^]
Maturity status: Test
(0112482)
hudsonbot (developer)
2019-06-06 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5f04242085fd [^]
Maturity status: Test
(0112483)
hudsonbot (developer)
2019-06-06 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5f04242085fd [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2019-06-05 16:43 caristu New Issue
2019-06-05 16:43 caristu Assigned To => platform
2019-06-05 16:43 caristu Modules => Core
2019-06-05 16:43 caristu Triggers an Emergency Pack => No
2019-06-05 16:43 caristu File Added: 41033_test_case.diff
2019-06-05 16:47 caristu Relationship added caused by 0039878
2019-06-05 16:49 caristu Regression level => Production - QA Approved
2019-06-05 16:49 caristu Regression date => 2019-01-08
2019-06-05 16:49 caristu Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/90c48060859cc70935add00e77e8065dedb197cc [^]
2019-06-05 16:50 caristu Relationship added related to 0034228
2019-06-05 16:50 caristu Status new => scheduled
2019-06-05 16:50 caristu Assigned To platform => caristu
2019-06-05 17:30 caristu Issue cloned 0041035
2019-06-05 17:30 caristu Relationship added related to 0041035
2019-06-06 11:00 hgbot Checkin
2019-06-06 11:00 hgbot Note Added: 0112456
2019-06-06 11:00 hgbot Status scheduled => resolved
2019-06-06 11:00 hgbot Resolution open => fixed
2019-06-06 11:00 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aebfddd2027d4005ee1eba6e753c21f608e7a7c3 [^]
2019-06-06 11:00 hgbot Checkin
2019-06-06 11:00 hgbot Note Added: 0112457
2019-06-06 11:00 hgbot Checkin
2019-06-06 11:00 hgbot Note Added: 0112458
2019-06-06 11:02 hgbot Checkin
2019-06-06 11:02 hgbot Note Added: 0112459
2019-06-06 11:03 hgbot Checkin
2019-06-06 11:03 hgbot Note Added: 0112460
2019-06-06 11:08 caristu Review Assigned To => alostale
2019-06-06 11:24 hgbot Checkin
2019-06-06 11:24 hgbot Note Added: 0112463
2019-06-06 11:44 hgbot Checkin
2019-06-06 11:44 hgbot Note Added: 0112465
2019-06-06 12:42 hgbot Checkin
2019-06-06 12:42 hgbot Note Added: 0112471
2019-06-06 13:22 hgbot Checkin
2019-06-06 13:22 hgbot Note Added: 0112473
2019-06-06 17:43 hudsonbot Checkin
2019-06-06 17:43 hudsonbot Note Added: 0112475
2019-06-06 17:43 hudsonbot Checkin
2019-06-06 17:43 hudsonbot Note Added: 0112476
2019-06-06 17:43 hudsonbot Checkin
2019-06-06 17:43 hudsonbot Note Added: 0112477
2019-06-06 17:43 hudsonbot Checkin
2019-06-06 17:43 hudsonbot Note Added: 0112478
2019-06-06 17:43 hudsonbot Checkin
2019-06-06 17:43 hudsonbot Note Added: 0112479
2019-06-06 17:43 hudsonbot Checkin
2019-06-06 17:43 hudsonbot Note Added: 0112480
2019-06-06 17:43 hudsonbot Checkin
2019-06-06 17:43 hudsonbot Note Added: 0112481
2019-06-06 17:43 hudsonbot Checkin
2019-06-06 17:43 hudsonbot Note Added: 0112482
2019-06-06 17:43 hudsonbot Checkin
2019-06-06 17:43 hudsonbot Note Added: 0112483
2019-06-07 08:00 alostale Status resolved => closed
2019-06-07 08:00 alostale Fixed in Version => 3.0PR19Q3
2019-06-07 08:19 alostale Regression introduced in release => 3.0PR19Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker