Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0041023 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] 09. Financial management | major | always | 2019-05-28 17:19 | 2019-06-05 16:45 | |||
| Reporter | ngarcia | View Status | public | |||||
| Assigned To | nonofrancisco | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR19Q2.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | dfb79e80d307 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR19Q2.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | Sandrahuguet | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2017-10-10 | |||||||
| Regression introduced in release | 3.0PR18Q1 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/9cf1f8c7de280894eb268e310a732b3e61cd128d [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0041023: Cannot open Payment Execution form if there are more than 1000 payment methods | |||||||
| Description | Cannot open Payment Execution form if there are more than 1000 payment methods | |||||||
| Steps To Reproduce | Log in with 'The White Valley Group Admin' role Open the Payment Execution window Check the following error is shown: "org.hibernate.exception.SQLGrammarException: could not execute query" The log shows: ERROR org.openbravo.advpaymentmngt.ad_forms.BatchPaymentExecution - Error captured: org.hibernate.exception.SQLGrammarException: could not extract ResultSet ... at org.openbravo.dal.service.OBCriteria.list(OBCriteria.java:103) ~[OBCriteria.class:?] at org.openbravo.advpaymentmngt.dao.AdvPaymentMngtDao.getFilteredPaymentMethods(AdvPaymentMngtDao.java:874) ~[AdvPaymentMngtDao.class:?] at org.openbravo.advpaymentmngt.utility.FIN_Utility.getPaymentMethodList(FIN_Utility.java:505) ~[FIN_Utility.class:?] at org.openbravo.advpaymentmngt.ad_forms.BatchPaymentExecution.printPageDataSheet(BatchPaymentExecution.java:205) ~[BatchPaymentExecution.class:?] at org.openbravo.advpaymentmngt.ad_forms.BatchPaymentExecution.doPost(BatchPaymentExecution.java:85) ~[BatchPaymentExecution.class:?] | |||||||
| Proposed Solution | The problem is in the addPaymentMethodList function of AdvPaymentMngtDao class. The following line is leaving the paymentMethods empty paymentMethods.removeAll(paymentMethodsToRemove); and the following instruction is not calculating the size correctly: paymentMethodsSize = paymentMethodsSize - 999; so the following condition is included in the query: or this_.Fin_Paymentmethod_ID in () | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0112433) hgbot (developer) 2019-06-05 16:44 |
Repository: erp/backports/3.0PR19Q2.1 Changeset: dfb79e80d3077f5408e3604dcca31820db0c3574 Author: Nono Carballo <nonofce <at> gmail.com> Date: Thu May 30 11:36:20 2019 -0400 URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/dfb79e80d3077f5408e3604dcca31820db0c3574 [^] Fixes issue 41023: Fixes getting Filter by Payment Method Avoids duplicates in list of payment method Id's. Fixes the way the filter is build when there are more than 1000 payment methods for filtering --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java --- |
|
(0112434) hgbot (developer) 2019-06-05 16:44 |
Repository: erp/backports/3.0PR19Q2.1 Changeset: 9636def9bef61b415120fd81b1fefb12548fab91 Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Wed Jun 05 16:10:12 2019 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/9636def9bef61b415120fd81b1fefb12548fab91 [^] related to issue 41023 reimplement the way to split the paymentMethods --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java --- |
|
(0112437) Sandrahuguet (developer) 2019-06-05 16:45 |
code review + testing ok |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-06-04 15:50 | nonofrancisco | Type | defect => backport |
| 2019-06-04 15:50 | nonofrancisco | Target Version | => 3.0PR19Q2.1 |
| 2019-06-05 16:44 | hgbot | Checkin | |
| 2019-06-05 16:44 | hgbot | Note Added: 0112433 | |
| 2019-06-05 16:44 | hgbot | Status | scheduled => resolved |
| 2019-06-05 16:44 | hgbot | Resolution | open => fixed |
| 2019-06-05 16:44 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/dfb79e80d3077f5408e3604dcca31820db0c3574 [^] |
| 2019-06-05 16:44 | hgbot | Checkin | |
| 2019-06-05 16:44 | hgbot | Note Added: 0112434 | |
| 2019-06-05 16:45 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
| 2019-06-05 16:45 | Sandrahuguet | Note Added: 0112437 | |
| 2019-06-05 16:45 | Sandrahuguet | Status | resolved => closed |
| 2019-06-05 16:45 | Sandrahuguet | Fixed in Version | => 3.0PR19Q2.1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |