Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040844
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] Z. Othersminorhave not tried2019-04-18 14:022019-06-04 17:56
ReporteralostaleView Statuspublic 
Assigned Tononofrancisco 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q2.1
StatusclosedFix in branchFixed in SCM revisionf1f88ee0b68b
ProjectionnoneETAnoneTarget Version3.0PR19Q2.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040844: use proper html escape in old selectors

DescriptionOld 2.50 selectors should use standard html escape rather than ad-hoc one.

Files to review:

$ grep -l "extends HttpSecureAppServlet" src/org/openbravo/erpCommon/info/*.java
src/org/openbravo/erpCommon/info/AccountElementValue.java
src/org/openbravo/erpCommon/info/Account.java
src/org/openbravo/erpCommon/info/AttributeSetInstance.java
src/org/openbravo/erpCommon/info/BusinessPartner.java
src/org/openbravo/erpCommon/info/BusinessPartnerMultiple.java
src/org/openbravo/erpCommon/info/DebtPayment.java
src/org/openbravo/erpCommon/info/DocTypeMultiple.java
src/org/openbravo/erpCommon/info/ImageInfoBLOB.java
src/org/openbravo/erpCommon/info/ImageInfo.java
src/org/openbravo/erpCommon/info/Invoice.java
src/org/openbravo/erpCommon/info/InvoiceLine.java
src/org/openbravo/erpCommon/info/Location.java
src/org/openbravo/erpCommon/info/Locator.java
src/org/openbravo/erpCommon/info/LocatorMultiple.java
src/org/openbravo/erpCommon/info/ProductComplete.java
src/org/openbravo/erpCommon/info/Product.java
src/org/openbravo/erpCommon/info/ProductMultiple.java
src/org/openbravo/erpCommon/info/Project.java
src/org/openbravo/erpCommon/info/ProjectMultiple.java
src/org/openbravo/erpCommon/info/SalesOrder.java
src/org/openbravo/erpCommon/info/SalesOrderLine.java
src/org/openbravo/erpCommon/info/ShipmentReceipt.java
src/org/openbravo/erpCommon/info/ShipmentReceiptLine.java
Steps To Reproduce-
Proposed SolutionSee attached example.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0040646 closednonofrancisco use proper html escape in old selectors 

-  Notes
(0112389)
hgbot (developer)
2019-06-04 17:54

Repository: erp/backports/3.0PR19Q2.1
Changeset: f1f88ee0b68bd2a6c9c80b2b0476a21e44c78881
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu May 09 14:52:16 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/f1f88ee0b68bd2a6c9c80b2b0476a21e44c78881 [^]

Fixes issue 40844: Escapes properly HTML characters.

Instead of escape HTML characters manually, a function to do so is used.

---
M src/org/openbravo/erpCommon/info/Account.java
M src/org/openbravo/erpCommon/info/AccountElementValue.java
M src/org/openbravo/erpCommon/info/BusinessPartner.java
M src/org/openbravo/erpCommon/info/BusinessPartnerMultiple.java
M src/org/openbravo/erpCommon/info/DebtPayment.java
M src/org/openbravo/erpCommon/info/DocTypeMultiple.java
M src/org/openbravo/erpCommon/info/Invoice.java
M src/org/openbravo/erpCommon/info/InvoiceLine.java
M src/org/openbravo/erpCommon/info/Locator.java
M src/org/openbravo/erpCommon/info/LocatorMultiple.java
M src/org/openbravo/erpCommon/info/Product.java
M src/org/openbravo/erpCommon/info/ProductComplete.java
M src/org/openbravo/erpCommon/info/ProductMultiple.java
M src/org/openbravo/erpCommon/info/Project.java
M src/org/openbravo/erpCommon/info/ProjectMultiple.java
M src/org/openbravo/erpCommon/info/SalesOrder.java
M src/org/openbravo/erpCommon/info/SalesOrderLine.java
M src/org/openbravo/erpCommon/info/ShipmentReceipt.java
M src/org/openbravo/erpCommon/info/ShipmentReceiptLine.java
---
(0112392)
Sandrahuguet (developer)
2019-06-04 17:56

code review + testing ok

- Issue History
Date Modified Username Field Change
2019-05-10 20:34 nonofrancisco Type defect => backport
2019-05-10 20:34 nonofrancisco Target Version => 3.0PR19Q2
2019-05-23 18:04 Sandrahuguet Target Version 3.0PR19Q2 => 3.0PR19Q2.1
2019-06-04 17:54 hgbot Checkin
2019-06-04 17:54 hgbot Note Added: 0112389
2019-06-04 17:54 hgbot Status scheduled => resolved
2019-06-04 17:54 hgbot Resolution open => fixed
2019-06-04 17:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/f1f88ee0b68bd2a6c9c80b2b0476a21e44c78881 [^]
2019-06-04 17:56 Sandrahuguet Review Assigned To => Sandrahuguet
2019-06-04 17:56 Sandrahuguet Note Added: 0112392
2019-06-04 17:56 Sandrahuguet Status resolved => closed
2019-06-04 17:56 Sandrahuguet Fixed in Version => 3.0PR19Q2.1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker