Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040812
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2019-05-08 16:082019-05-30 16:03
ReporteranderarangurenView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityimmediateResolutionfixedFixed in VersionRR19Q3
StatusclosedFix in branchFixed in SCM revision262e8aeedacd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040812: If a manual discount is applied to an order, it is not possible to apply it again. It will remain the first discount

DescriptionIf a manual discount is applied to an order, it is not possible to apply it again. It will remain the first discount

Even if it is a different percentage or amount.

It is also not possible to add the second discount by checking "Override existing promotions"
Steps To Reproduce1. Go to Web POS
2. Add a product
3. Click on Discount button
4. Add disc_5_var_perc_5% discount
5. Click again on Discount Button
6. Add the same discount but with different percentage (10%)
The second time, the discount will not be applied. 5% discount will remain.

7. Try adding again (10%) by checking "Override existing promotions"
It does not override the first one. 5% discount will still remain.
TagsNo tags attached.
Attached Filespatch file icon issue 40812 source posterminal.patch [^] (4,324 bytes) 2019-05-21 07:51 [Show Content]
patch file icon issue 40812 source test.patch [^] (8,097 bytes) 2019-05-21 07:51 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0040817 closedranjith_qualiantech_com Applying a User Defined Percentage twice, it gives a wrong value. 
related to defect 0040666 closedranjith_qualiantech_com Several discounts do not apply to all lines 
related to design defect 0040979 newRetail Discounts defined as "Allow multiple instances per line" should hide or disable "Override existing promotions" check 

-  Notes
(0111678)
hgbot (developer)
2019-05-15 08:09

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c2d2d09ffd128a9a7f4e1fbbee1cffad093ce815
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 15 11:39:23 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c2d2d09ffd128a9a7f4e1fbbee1cffad093ce815 [^]

Fixed issue 40812 : Manual Promotions should override the existing promotions present in the receipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0111679)
hgbot (developer)
2019-05-15 08:09

Repository: tools/automation/pi-mobile
Changeset: 4d3cc1d59f2519c683bda653d2c9d675046872cb
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 15 11:39:39 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/4d3cc1d59f2519c683bda653d2c9d675046872cb [^]

Verifies issue 40812 : Modified MultiDiscounts automated test

* Multidiscounts_FixedAmount.java
* Multidiscounts_FixedPercentage.java
* Multidiscounts_VariableAmount.java
* Multidiscounts_VariablePercentage.java

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multidiscounts/Multidiscounts_FixedAmount.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multidiscounts/Multidiscounts_FixedPercentage.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multidiscounts/Multidiscounts_VariableAmount.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multidiscounts/Multidiscounts_VariablePercentage.java
---
(0111717)
jorge-garcia (developer)
2019-05-16 12:35

The solution is not completely correct.

In this scenario, the only point which is wrong is the one defined in step 7.

Unless "Allow multiple instances per line" is set in discount configuration, if the user tries to apply the same manual promotion twice, even if the percentage or amount to discount is different, the manual promotion should no change.

This behavior is different if the user sets the override check, in this case, the previous promotion must be deleted and the new one must be applied.
(0111778)
hgbot (developer)
2019-05-20 04:25

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cf57663aa8d4a9854498397258359b71f4dcf406
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 20 07:53:53 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf57663aa8d4a9854498397258359b71f4dcf406 [^]

Fixed issue 40812 : Backed out changeset: c2d2d09ffd12

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0111779)
hgbot (developer)
2019-05-20 04:32

Repository: tools/automation/pi-mobile
Changeset: 2ee962a4292c6eadc87792f32f9eb1352859e096
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 20 07:53:22 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2ee962a4292c6eadc87792f32f9eb1352859e096 [^]

Verifies issue 40812 : Backed out changeset: 4d3cc1d59f25

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multidiscounts/Multidiscounts_FixedAmount.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multidiscounts/Multidiscounts_FixedPercentage.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multidiscounts/Multidiscounts_VariableAmount.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multidiscounts/Multidiscounts_VariablePercentage.java
---
(0112057)
hgbot (developer)
2019-05-22 04:29

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 262e8aeedacdd03e99c860fbf57619be735ef3e4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 22 07:58:48 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/262e8aeedacdd03e99c860fbf57619be735ef3e4 [^]

Fixed issue 40812 : Manual Promotions should not override the existing promotions present in the receipt

* When applying manual promotion, if override option is checked, then existing manual promotion should be replaced by new manual promotion.
  If override option is not checked, it should not replace existing manual promotion
* Manual promotion doesn't consume the qtyOffer. So if manual promotion is added with override option, it should not replace the automatic discounts

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0112058)
hgbot (developer)
2019-05-22 04:29

Repository: tools/automation/pi-mobile
Changeset: 0aec79ceddc7bf903c12386fddfd07acf3d909c6
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 22 07:55:22 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0aec79ceddc7bf903c12386fddfd07acf3d909c6 [^]

Verifies issue 40812 : Added automated test 'I40812_VerifyMultiManualDiscounts'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I40812_VerifyMultiManualDiscounts.java
---
(0112078)
jorge-garcia (developer)
2019-05-23 09:48

The following basic scenario is not working

1) Add a product to the ticket
2) Apply a discount of "disc_5_var_perc - 5%" to all lines
3) Check the promotion is added to the line (this is correct)
4) Try to apply to all lines the same promotion with a 10%
5) Check the 5% promotion is in the ticket and 10% not (this is correct)
6) Try to apply to all lines the same promotion with a 15% and with Override flag checked.
7) Check the 5% promotion is in the ticket and 15% not (this is wrong).

This scenario has been tested in a environment with all external modules installed.
(0112154)
hgbot (developer)
2019-05-27 09:31

Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 2b9c28f2fe3250e21cf413407157e38ffef9dd55
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 27 13:00:51 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/2b9c28f2fe3250e21cf413407157e38ffef9dd55 [^]

Related to issue 40812 : Order Manual Promotions should be reset when total discount is applied with override flag checked

* If Multiple Instance is enabled and override is selected, then Order Manual Promotions should be reset

---
M web/org.openbravo.retail.discounts.bytotal/js/preApplyDiscountsHook.js
---
(0112165)
hgbot (developer)
2019-05-27 12:56

Repository: tools/automation/pi-mobile
Changeset: 68c640fc6864989075ee18820cb74ea6252d4021
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 27 16:26:46 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/68c640fc6864989075ee18820cb74ea6252d4021 [^]

Verifies issue 40812 : Added automated test 'I40812_VerifyMultiManualTotalDiscounts'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I40812_VerifyMultiManualDiscounts.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I40812_VerifyMultiManualTotalDiscounts.java
---
(0112275)
jorge-garcia (developer)
2019-05-30 16:03

Code reviewed and tested

- Issue History
Date Modified Username Field Change
2019-05-08 16:08 anderaranguren New Issue
2019-05-08 16:08 anderaranguren Assigned To => Retail
2019-05-08 16:08 anderaranguren Triggers an Emergency Pack => No
2019-05-09 09:58 anderaranguren Description Updated View Revisions
2019-05-09 09:58 anderaranguren Steps to Reproduce Updated View Revisions
2019-05-09 10:15 anderaranguren Relationship added related to 0040817
2019-05-09 10:23 anderaranguren Priority urgent => immediate
2019-05-09 14:22 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2019-05-09 14:23 ranjith_qualiantech_com Status new => scheduled
2019-05-14 17:48 martinsdan Issue Monitored: martinsdan
2019-05-15 08:09 hgbot Checkin
2019-05-15 08:09 hgbot Note Added: 0111678
2019-05-15 08:09 hgbot Status scheduled => resolved
2019-05-15 08:09 hgbot Resolution open => fixed
2019-05-15 08:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c2d2d09ffd128a9a7f4e1fbbee1cffad093ce815 [^]
2019-05-15 08:09 hgbot Checkin
2019-05-15 08:09 hgbot Note Added: 0111679
2019-05-16 12:26 jorge-garcia Review Assigned To => jorge-garcia
2019-05-16 12:35 jorge-garcia Note Added: 0111717
2019-05-16 12:35 jorge-garcia Status resolved => new
2019-05-16 12:35 jorge-garcia Resolution fixed => open
2019-05-17 07:30 ranjith_qualiantech_com Status new => scheduled
2019-05-20 04:25 hgbot Checkin
2019-05-20 04:25 hgbot Note Added: 0111778
2019-05-20 04:25 hgbot Status scheduled => resolved
2019-05-20 04:25 hgbot Resolution open => fixed
2019-05-20 04:25 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c2d2d09ffd128a9a7f4e1fbbee1cffad093ce815 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf57663aa8d4a9854498397258359b71f4dcf406 [^]
2019-05-20 04:32 hgbot Checkin
2019-05-20 04:32 hgbot Note Added: 0111779
2019-05-20 14:42 ranjith_qualiantech_com Status resolved => new
2019-05-20 14:42 ranjith_qualiantech_com Resolution fixed => open
2019-05-20 14:42 ranjith_qualiantech_com Status new => scheduled
2019-05-21 07:51 ranjith_qualiantech_com File Added: issue 40812 source posterminal.patch
2019-05-21 07:51 ranjith_qualiantech_com Assigned To ranjith_qualiantech_com => anderaranguren
2019-05-21 07:51 ranjith_qualiantech_com Assigned To anderaranguren => ranjith_qualiantech_com
2019-05-21 07:51 ranjith_qualiantech_com File Added: issue 40812 source test.patch
2019-05-22 04:29 hgbot Checkin
2019-05-22 04:29 hgbot Note Added: 0112057
2019-05-22 04:29 hgbot Status scheduled => resolved
2019-05-22 04:29 hgbot Resolution open => fixed
2019-05-22 04:29 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cf57663aa8d4a9854498397258359b71f4dcf406 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/262e8aeedacdd03e99c860fbf57619be735ef3e4 [^]
2019-05-22 04:29 hgbot Checkin
2019-05-22 04:29 hgbot Note Added: 0112058
2019-05-23 09:48 jorge-garcia Note Added: 0112078
2019-05-23 09:48 jorge-garcia Status resolved => new
2019-05-23 09:48 jorge-garcia Resolution fixed => open
2019-05-23 12:10 ranjith_qualiantech_com Status new => scheduled
2019-05-27 09:31 hgbot Checkin
2019-05-27 09:31 hgbot Note Added: 0112154
2019-05-27 11:52 jorgewederago Relationship added related to 0040666
2019-05-27 12:56 hgbot Checkin
2019-05-27 12:56 hgbot Note Added: 0112165
2019-05-27 13:52 ranjith_qualiantech_com Status scheduled => resolved
2019-05-27 13:52 ranjith_qualiantech_com Resolution open => fixed
2019-05-30 16:02 jorge-garcia Relationship added related to 0040979
2019-05-30 16:03 jorge-garcia Note Added: 0112275
2019-05-30 16:03 jorge-garcia Status resolved => closed
2019-05-30 16:03 jorge-garcia Fixed in Version => RR19Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker