0040772: SL_TaxCategory_Org.execute is not using bind-parameters

Description

This method is not using bind-parameters in lines 49 + 58

      whereClause = "as tn where tn.node = '" + organization.getId() + "' and tn.client.id = '"
          + organization.getClient().getId() + "'";

        OBQuery<TreeNode> query = OBDal.getInstance().createQuery(TreeNode.class, whereClause);

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0040559

closed

nonofrancisco

SL_TaxCategory_Org.execute is not using bind-parameters

Notes
(0111571) hgbot (developer) 2019-05-08 12:46	Repository: erp/backports/3.0PR19Q2 Changeset: 5b358f1d263fdea6b752ad6fcb32e3466aa8ffdf Author: Nono Carballo <nonofce <at> gmail.com> Date: Mon Apr 22 15:04:05 2019 -0400 URL: http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/5b358f1d263fdea6b752ad6fcb32e3466aa8ffdf [^] Fixes issue 40772: Uses bind parameters in query Instead of using string concatenation in client and organization filters in where clause, bind parameters are used --- M src/org/openbravo/erpCommon/ad_callouts/SL_TaxCategory_Org.java ---

(0111572) Sandrahuguet (viewer) 2019-05-08 12:46	code review + testing ok

Issue History
Date Modified	Username	Field	Change
2019-05-04 16:55	nonofrancisco	Type	defect => backport
2019-05-04 16:55	nonofrancisco	Target Version	=> 3.0PR19Q2
2019-05-08 12:46	hgbot	Checkin
2019-05-08 12:46	hgbot	Note Added: 0111571
2019-05-08 12:46	hgbot	Status	scheduled => resolved
2019-05-08 12:46	hgbot	Resolution	open => fixed
2019-05-08 12:46	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/5b358f1d263fdea6b752ad6fcb32e3466aa8ffdf [^]
2019-05-08 12:46	Sandrahuguet	Review Assigned To	=> Sandrahuguet
2019-05-08 12:46	Sandrahuguet	Note Added: 0111572
2019-05-08 12:46	Sandrahuguet	Status	resolved => closed
2019-05-08 12:46	Sandrahuguet	Fixed in Version	=> 3.0PR19Q2