Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040772
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 07. Sales managementminorhave not tried2019-04-09 20:292019-05-08 12:46
ReportershuehnerView Statuspublic 
Assigned Tononofrancisco 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q2
StatusclosedFix in branchFixed in SCM revision5b358f1d263f
ProjectionnoneETAnoneTarget Version3.0PR19Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040772: SL_TaxCategory_Org.execute is not using bind-parameters

DescriptionThis method is not using bind-parameters in lines 49 + 58

      whereClause = "as tn where tn.node = '" + organization.getId() + "' and tn.client.id = '"
          + organization.getClient().getId() + "'";

        OBQuery<TreeNode> query = OBDal.getInstance().createQuery(TreeNode.class, whereClause);
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0040559 closednonofrancisco SL_TaxCategory_Org.execute is not using bind-parameters 

-  Notes
(0111571)
hgbot (developer)
2019-05-08 12:46

Repository: erp/backports/3.0PR19Q2
Changeset: 5b358f1d263fdea6b752ad6fcb32e3466aa8ffdf
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Apr 22 15:04:05 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/5b358f1d263fdea6b752ad6fcb32e3466aa8ffdf [^]

Fixes issue 40772: Uses bind parameters in query

Instead of using string concatenation in client and organization filters in
where clause, bind parameters are used

---
M src/org/openbravo/erpCommon/ad_callouts/SL_TaxCategory_Org.java
---
(0111572)
Sandrahuguet (developer)
2019-05-08 12:46

code review + testing ok

- Issue History
Date Modified Username Field Change
2019-05-04 16:55 nonofrancisco Type defect => backport
2019-05-04 16:55 nonofrancisco Target Version => 3.0PR19Q2
2019-05-08 12:46 hgbot Checkin
2019-05-08 12:46 hgbot Note Added: 0111571
2019-05-08 12:46 hgbot Status scheduled => resolved
2019-05-08 12:46 hgbot Resolution open => fixed
2019-05-08 12:46 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2/rev/5b358f1d263fdea6b752ad6fcb32e3466aa8ffdf [^]
2019-05-08 12:46 Sandrahuguet Review Assigned To => Sandrahuguet
2019-05-08 12:46 Sandrahuguet Note Added: 0111572
2019-05-08 12:46 Sandrahuguet Status resolved => closed
2019-05-08 12:46 Sandrahuguet Fixed in Version => 3.0PR19Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker