Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0040599 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] 09. Financial management | minor | have not tried | 2019-04-11 15:13 | 2019-05-21 15:16 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | Triage Omni OMS | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR19Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 8babe1f19082 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | Sandrahuguet | |||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0040599: Stop using Vector<Object> where not useful as its bad coding style | |||||||
Description | Both: - PaymentReportDao - CashflowForecastReportActionHandler use Vector<Object> with no good reason as they only put single type inside ever. Apart of being bad-coding practice making code harder to read fixing it also works around bug in external code-checking tool. https://github.com/typetools/checker-framework/issues/2422 [^] Note for the fix: In PaymentReportDao the objectNames=="" was simplified instead of just fixing the type confusion. | |||||||
Steps To Reproduce | - | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
|
![]() |
|
(0111085) shuehner (administrator) 2019-04-11 15:14 |
Note: Patch is only compile tested so far |
(0111167) hgbot (developer) 2019-04-16 15:28 |
Repository: erp/devel/pi Changeset: 8babe1f19082d00c4ca22a97dc226271cf2b7286 Author: Stefan Huehner <stefan.huehner <at> openbravo.com> Date: Tue Apr 16 09:38:15 2019 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/8babe1f19082d00c4ca22a97dc226271cf2b7286 [^] Fixed issue 40599 Stop using Vector<Object> where not useful as its bad coding style --- M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java M src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java --- |
(0111168) Sandrahuguet (viewer) 2019-04-16 15:29 |
Code review + testing OK |
(0111977) hudsonbot (viewer) 2019-05-21 15:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^] Maturity status: Test |
![]() |
|||
Date Modified | Username | Field | Change |
2019-04-11 15:13 | shuehner | New Issue | |
2019-04-11 15:13 | shuehner | Assigned To | => Triage Finance |
2019-04-11 15:13 | shuehner | OBNetwork customer | => No |
2019-04-11 15:13 | shuehner | Modules | => Core |
2019-04-11 15:13 | shuehner | Triggers an Emergency Pack | => No |
2019-04-11 15:14 | shuehner | File Added: 40599.diff | |
2019-04-11 15:14 | shuehner | Note Added: 0111085 | |
2019-04-16 15:28 | hgbot | Checkin | |
2019-04-16 15:28 | hgbot | Note Added: 0111167 | |
2019-04-16 15:28 | hgbot | Status | new => resolved |
2019-04-16 15:28 | hgbot | Resolution | open => fixed |
2019-04-16 15:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/8babe1f19082d00c4ca22a97dc226271cf2b7286 [^] |
2019-04-16 15:29 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
2019-04-16 15:29 | Sandrahuguet | Note Added: 0111168 | |
2019-04-16 15:29 | Sandrahuguet | Status | resolved => closed |
2019-04-16 15:29 | Sandrahuguet | Fixed in Version | => 3.0PR19Q3 |
2019-05-21 15:16 | hudsonbot | Checkin | |
2019-05-21 15:16 | hudsonbot | Note Added: 0111977 |
Copyright © 2000 - 2009 MantisBT Group |