Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040494
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Copy Retail Storemajoralways2019-03-29 13:332019-06-11 12:00
ReporterucarrionView Statuspublic 
Assigned Torqueralta 
PriorityhighResolutionfixedFixed in VersionRR19Q3
StatusclosedFix in branchFixed in SCM revision91fe78eaadd9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040494: Several fields not copied when using 'Copy Terminal' process

DescriptionSeveral fields not copied when using 'Copy Terminal' process

'Return No Prefix'
'Gift Certificate Sequence Prefix'
Steps To ReproduceThe prefix must be copied (change the original by the new one) in these all fields
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0040740 closedranjith_qualiantech_com Field not copied when using 'Copy Terminal' process 

-  Notes
(0111219)
hgbot (developer)
2019-04-22 18:16

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: b80ef3ffc14d8d7c47a713053bbdab8f7626fd75
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Apr 22 12:08:43 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/b80ef3ffc14d8d7c47a713053bbdab8f7626fd75 [^]

Fixed issue 40494: Several fields not copied when using 'Copy Terminal' process

- Copied and replaced by the new value, missing fields in 'Copy Terminal' process

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0111244)
adrianromero (manager)
2019-04-23 17:55

The copy definition for the field 'gcnvGcseqPrefix' is already defined in another module and must not go in posterminal: https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/file/tip/src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java [^]

If the user wants to copy this field he must install org.openbravo.retail.copystore.giftcards
(0111249)
hgbot (developer)
2019-04-23 21:53

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 1722a6495af27ea639f1eb234c4ff1cc51b6ca3b
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Apr 23 15:28:15 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/1722a6495af27ea639f1eb234c4ff1cc51b6ca3b [^]

Related to issue 40494: Several fields not copied when using 'Copy Terminal'
process

- Removed changes in giftcard prefix

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0111275)
hgbot (developer)
2019-04-24 13:14

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 7cbf5e54718b87ccb7a7a8abd4d31f5f54bc7b4b
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Apr 24 13:14:38 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/7cbf5e54718b87ccb7a7a8abd4d31f5f54bc7b4b [^]

Reverting all changes in issue 40494: Several fields not copied when using 'Copy Terminal' process
Issue has been rejected

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0111276)
adrianromero (manager)
2019-04-24 13:19

No need to do any modification of the behavior:

'Return No Prefix' No need to save any value in this field when copy a terminal. By default the prefix of a return will be the order prefix. This is the expected behaviour when copying a terminal.

'Gift Certificate Sequence Prefix'. The copy of this field is managed in the module org.openbravo.retail.copystore.giftcards that needs to be installed first to copy the field when copying a terminal.
(0111307)
ucarrion (developer)
2019-04-25 11:58

Hi,

if indicated in original terminal, the copied terminal should be in coherence with its new prefix (see example screenshot below).

https://drive.google.com/drive/folders/0BzzTCqxUdgWYfl84M0lJd0I4b3Z3VHEwd0JzLVJ4ckRNR3V1SDlodnRLcDF0ajNfWVIyeUk [^]
(0111316)
hgbot (developer)
2019-04-25 13:20

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: b69fd996ad595541d0c46d55221dbbf68bb14644
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Apr 25 13:10:25 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/b69fd996ad595541d0c46d55221dbbf68bb14644 [^]

Backed out changeset 7cbf5e54718b Reverting all changes in issue 40494: Several fields not copied when using 'Copy Terminal' process

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0111317)
adrianromero (manager)
2019-04-25 13:22

Finally it is needed to save a new 'Return No Prefix' to not to copy the value from the previous terminal and have a new one based on the search key of the new terminal.
(0111318)
adrianromero (manager)
2019-04-25 13:22

Verified
(0111420)
ucarrion (developer)
2019-05-02 09:21

Hi,

the process is not working correctly also for 'Order Preparation No Prefix' field. See the screeshot below taken from livebuilds:

https://drive.google.com/file/d/1zeNUehBmpGAIa7cwP8F_1g8JgqSmpU5T/view?usp=sharing [^]
(0111429)
adrianromero (manager)
2019-05-02 12:10

A new issue has been created to make reference to a new field not properly managed in the copy terminal process -> 0040740
(0112097)
barbararoncato (developer)
2019-05-23 16:37

Hi, the below fields are still not created correctly:

Order Quotation No Prefix
Return No Prefix
Order Document No Prefix
Order Preparation No Prefix
Gift Certificate Sequence Prefix

Please see video from livebuilds:
https://drive.google.com/file/d/1QteoK_2j-JgJIwRYGYMGp8QDHfI605Hs/view [^]
(0112188)
hgbot (developer)
2019-05-27 21:35

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: e2d3b1ce0a62ff651e4bebc6582e05eda55d2c1a
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon May 27 15:29:58 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/e2d3b1ce0a62ff651e4bebc6582e05eda55d2c1a [^]

Fixed issue 40494: Several fields not copied when using 'Copy Terminal' process

- Added suffix to the searchKey by Document Type

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0112190)
hgbot (developer)
2019-05-27 22:55

Repository: erp/pmods/org.openbravo.retail.copystore.giftcards
Changeset: 91fe78eaadd9d648986b166909d5ecdc69f97782
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon May 27 16:55:40 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/91fe78eaadd9d648986b166909d5ecdc69f97782 [^]

Fixed issue 40494: Several fields not copied when using 'Copy Terminal' process

- Added "GC" suffix to the new searchKey

---
M src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java
---
(0112322)
hgbot (developer)
2019-05-31 19:42

Repository: erp/pmods/org.openbravo.retail.copystore.giftcards
Changeset: 09ca466136e82b17c6a36a43b4ed592e571e9c5d
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Fri May 31 13:41:01 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/09ca466136e82b17c6a36a43b4ed592e571e9c5d [^]

Related issue 40494: Several fields not copied when using 'Copy Terminal' process

- Restored qualifier values

---
M src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java
---
(0112336)
ranjith_qualiantech_com (developer)
2019-06-03 12:25

While copying Terminal, if prefixNo(return, quotation, orderpreparation) is empty, then new terminal prefixno should be empty else prefixNo should be updated with new terminal searchKey
(0112337)
hgbot (developer)
2019-06-03 14:59

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 612ffc8d2a31a165dba9ed999ba03dac17ccded4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 03 18:28:54 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/612ffc8d2a31a165dba9ed999ba03dac17ccded4 [^]

Related to issue 40494 : Prefix No should be copied if the value is empty in Old terminal

* While copying terminal, if prefixNo is empty in old Terminal then same should be copied to new terminal
  instead of updating with new terminal searchKey

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0112407)
hgbot (developer)
2019-06-05 10:13

Repository: erp/pmods/org.openbravo.retail.copystore.giftcards
Changeset: f432a22a77fb1fdab0c4a9cfbd01c4c7f82c6077
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 05 13:43:16 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/f432a22a77fb1fdab0c4a9cfbd01c4c7f82c6077 [^]

Related to issue 40494 : Prefix No should be set as empty if the value is empty in Old terminal

* While copying terminal, if prefixNo is empty in old Terminal then same should be copied to new terminal
instead of updating with new terminal searchKey

---
M src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java
---
(0112576)
hgbot (developer)
2019-06-11 12:00

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 4f9efb601cd79b38da8de65123bd5f13c6a93b16
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 11 15:30:27 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/4f9efb601cd79b38da8de65123bd5f13c6a93b16 [^]

Related to issue 40494 : Updates Standard Package Import for StringUtils

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0112577)
hgbot (developer)
2019-06-11 12:00

Repository: erp/pmods/org.openbravo.retail.copystore.giftcards
Changeset: d7bbec3b0170e7d950480cba625c762e6c8f5efd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 11 15:30:29 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/d7bbec3b0170e7d950480cba625c762e6c8f5efd [^]

Related to issue 40494 : Updates Standard Package Import for StringUtils

---
M src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java
---

- Issue History
Date Modified Username Field Change
2019-03-29 13:33 ucarrion New Issue
2019-03-29 13:33 ucarrion Assigned To => Triage Finance
2019-03-29 13:33 ucarrion Modules => Core
2019-03-29 13:33 ucarrion Triggers an Emergency Pack => No
2019-03-29 14:16 Sandrahuguet Assigned To Triage Finance => markmm82
2019-03-29 14:22 Sandrahuguet Assigned To markmm82 => Retail
2019-03-29 14:24 Sandrahuguet Project Openbravo ERP => Retail Modules
2019-03-29 14:25 Sandrahuguet Category 02. Master data management => Copy Retail Store
2019-03-29 16:27 markmm82 Status new => scheduled
2019-03-31 20:20 markmm82 Status scheduled => feedback
2019-03-31 20:20 markmm82 Status feedback => new
2019-04-01 03:28 rqueralta Assigned To Retail => rqueralta
2019-04-01 03:28 rqueralta Status new => scheduled
2019-04-22 18:16 hgbot Checkin
2019-04-22 18:16 hgbot Note Added: 0111219
2019-04-22 18:16 hgbot Status scheduled => resolved
2019-04-22 18:16 hgbot Resolution open => fixed
2019-04-22 18:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/b80ef3ffc14d8d7c47a713053bbdab8f7626fd75 [^]
2019-04-23 17:55 adrianromero Note Added: 0111244
2019-04-23 17:55 adrianromero Status resolved => new
2019-04-23 17:55 adrianromero Resolution fixed => open
2019-04-23 21:53 hgbot Checkin
2019-04-23 21:53 hgbot Note Added: 0111249
2019-04-23 23:30 rqueralta Status new => scheduled
2019-04-23 23:30 rqueralta Status scheduled => resolved
2019-04-23 23:30 rqueralta Resolution open => fixed
2019-04-24 13:14 hgbot Checkin
2019-04-24 13:14 hgbot Note Added: 0111275
2019-04-24 13:15 adrianromero Status resolved => new
2019-04-24 13:15 adrianromero Resolution fixed => open
2019-04-24 13:19 adrianromero Review Assigned To => adrianromero
2019-04-24 13:19 adrianromero Note Added: 0111276
2019-04-24 13:19 adrianromero Status new => closed
2019-04-24 13:19 adrianromero Resolution open => no change required
2019-04-25 11:58 ucarrion Assigned To rqueralta => adrianromero
2019-04-25 11:58 ucarrion Note Added: 0111307
2019-04-25 11:58 ucarrion Status closed => new
2019-04-25 11:58 ucarrion Resolution no change required => open
2019-04-25 13:20 hgbot Checkin
2019-04-25 13:20 hgbot Note Added: 0111316
2019-04-25 13:21 adrianromero Status new => scheduled
2019-04-25 13:22 adrianromero Note Added: 0111317
2019-04-25 13:22 adrianromero Status scheduled => resolved
2019-04-25 13:22 adrianromero Fixed in Version => RR19Q3
2019-04-25 13:22 adrianromero Resolution open => fixed
2019-04-25 13:22 adrianromero Note Added: 0111318
2019-04-25 13:22 adrianromero Status resolved => closed
2019-05-02 09:21 ucarrion Note Added: 0111420
2019-05-02 09:21 ucarrion Status closed => new
2019-05-02 09:21 ucarrion Resolution fixed => open
2019-05-02 09:21 ucarrion Fixed in Version RR19Q3 =>
2019-05-02 12:08 adrianromero Status new => scheduled
2019-05-02 12:08 adrianromero Status scheduled => resolved
2019-05-02 12:08 adrianromero Resolution open => fixed
2019-05-02 12:10 adrianromero Note Added: 0111429
2019-05-02 12:10 adrianromero Status resolved => closed
2019-05-02 12:10 adrianromero Fixed in Version => RR19Q3
2019-05-02 12:10 adrianromero Relationship added related to 0040740
2019-05-23 16:37 barbararoncato Note Added: 0112097
2019-05-23 16:38 barbararoncato Status closed => new
2019-05-23 16:38 barbararoncato Resolution fixed => open
2019-05-23 16:38 barbararoncato Fixed in Version RR19Q3 =>
2019-05-24 12:03 marvintm Review Assigned To adrianromero =>
2019-05-24 12:03 marvintm Assigned To adrianromero => rqueralta
2019-05-27 21:35 hgbot Checkin
2019-05-27 21:35 hgbot Note Added: 0112188
2019-05-27 21:35 hgbot Status new => resolved
2019-05-27 21:35 hgbot Resolution open => fixed
2019-05-27 21:35 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/b80ef3ffc14d8d7c47a713053bbdab8f7626fd75 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/e2d3b1ce0a62ff651e4bebc6582e05eda55d2c1a [^]
2019-05-27 22:55 hgbot Checkin
2019-05-27 22:55 hgbot Note Added: 0112190
2019-05-27 22:55 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/e2d3b1ce0a62ff651e4bebc6582e05eda55d2c1a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore.giftcards/rev/91fe78eaadd9d648986b166909d5ecdc69f97782 [^]
2019-05-31 09:13 marvintm Review Assigned To => marvintm
2019-05-31 09:13 marvintm Status resolved => closed
2019-05-31 09:13 marvintm Fixed in Version => RR19Q3
2019-05-31 19:42 hgbot Checkin
2019-05-31 19:42 hgbot Note Added: 0112322
2019-06-03 12:25 ranjith_qualiantech_com Note Added: 0112336
2019-06-03 12:25 ranjith_qualiantech_com Status closed => new
2019-06-03 12:25 ranjith_qualiantech_com Resolution fixed => open
2019-06-03 12:25 ranjith_qualiantech_com Fixed in Version RR19Q3 =>
2019-06-03 14:59 hgbot Checkin
2019-06-03 14:59 hgbot Note Added: 0112337
2019-06-04 08:32 ranjith_qualiantech_com Status new => scheduled
2019-06-04 08:32 ranjith_qualiantech_com Status scheduled => resolved
2019-06-04 08:32 ranjith_qualiantech_com Resolution open => fixed
2019-06-05 10:13 hgbot Checkin
2019-06-05 10:13 hgbot Note Added: 0112407
2019-06-05 15:16 marvintm Status resolved => closed
2019-06-05 15:16 marvintm Fixed in Version => RR19Q3
2019-06-11 12:00 hgbot Checkin
2019-06-11 12:00 hgbot Note Added: 0112576
2019-06-11 12:00 hgbot Checkin
2019-06-11 12:00 hgbot Note Added: 0112577


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker