Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0040404

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2019-03-18 13:18

2019-03-28 14:10

Reporter

malsasua

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

RR19Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0040404: Verystar is locked when payment method is changed

Description

When user first select one verystar payment method, and after that, change to another verystar payment method, the request to check if the payment has been completed are not executed for the second payment method

Steps To Reproduce

[POS]
. do login
. add line
. pay using Verystar payment method pm1
  -> barcode is displayed
  -> in Chrome Developers Tools -> Network tab -> new requests are created to check if the payment has been done
. cancel payment with pm1
. pay using verystar payment method pm2
  -> barcode is displayed
  -> in Chrome Developers Tools -> Network tab -> the new requests are not created, so, never is checked if the payment has been completed or not-> ERROR

Proposed Solution

See attachments

Tags

No tags attached.

issueVeryStar_org.openbravo.retail.verystar.diff [^] (745 bytes) 2019-03-18 13:30 [Show Content] [Hide Content]

# HG changeset patch
# User Miguel A. Alsasua <miguel.alsasua@openbravo.com>
# Date 1552847414 -3600
# Node ID 0ed21912ba2fd75c3dfe16f1479cbe5988cf37cb
# Parent  be896f52ae6729b3ecd58d8242a8427acdab18d2
ticket 8687: no lock when payment method change from AliPay to WeChat

diff --git a/web/org.openbravo.retail.verystar/js/provider/qrProvider.js b/web/org.openbravo.retail.verystar/js/provider/qrProvider.js
--- a/web/org.openbravo.retail.verystar/js/provider/qrProvider.js
+++ b/web/org.openbravo.retail.verystar/js/provider/qrProvider.js
@@ -103,6 +103,7 @@
     if (OBVER.UTIL.interval) {
       clearInterval(OBVER.UTIL.interval);
     }
+    OBVER.UTIL.interval=null;
   },
   initComponents: function () {
     this.inherited(arguments);

issueVeryStar_org.openbravo.retail.selfcheckout.verystar.diff [^] (813 bytes) 2019-03-18 13:30 [Show Content] [Hide Content]

# HG changeset patch
# User Miguel A. Alsasua <miguel.alsasua@openbravo.com>
# Date 1552898274 -3600
# Node ID 551bf794552ec2849845d23fb64e16f96a7b3ac1
# Parent  3e0046108a81964f0bf13d0648d34fe85815c532
ticket 8687: no lock when payment method change from AliPay to WeChat

diff --git a/web/org.openbravo.retail.selfcheckout.verystar/js/panels/mobilePaymentPanel.js b/web/org.openbravo.retail.selfcheckout.verystar/js/panels/mobilePaymentPanel.js
--- a/web/org.openbravo.retail.selfcheckout.verystar/js/panels/mobilePaymentPanel.js
+++ b/web/org.openbravo.retail.selfcheckout.verystar/js/panels/mobilePaymentPanel.js
@@ -20,6 +20,7 @@
     if (OBVER.UTIL.interval) {
       clearInterval(OBVER.UTIL.interval);
     }
+    OBVER.UTIL.interval=null;
     this.executeEvent({
       name: 'GoSelectPayment'
     });

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

ranjith_qualiantech_com

Verystar is locked when Force button is clicked

Notes
(0110488) hgbot (developer) 2019-03-19 10:42	Repository: erp/pmods/org.openbravo.retail.selfcheckout.verystar Changeset: 98f8304b47d867cb6fc04c91a7af187117b0efff Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Mar 19 15:12:34 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.selfcheckout.verystar/rev/98f8304b47d867cb6fc04c91a7af187117b0efff [^] Related to issue 40404 : Validated Order Query interval * Refactored clearInterval and added new method in OBVER.UTIL --- M web/org.openbravo.retail.selfcheckout.verystar/js/hooks/preNavigatePOSHook.js M web/org.openbravo.retail.selfcheckout.verystar/js/panels/mobilePaymentPanel.js ---

(0110489) hgbot (developer) 2019-03-19 10:42	Repository: erp/pmods/org.openbravo.retail.verystar Changeset: 445582f331bf9c36bb312f58972746431aabb20f Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Mar 19 15:12:31 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.verystar/rev/445582f331bf9c36bb312f58972746431aabb20f [^] Related to issue 40404 : Validated Order Query interval * Refactored clearInterval and added new method in OBVER.UTIL --- M web/org.openbravo.retail.verystar/js/provider/qrProvider.js M web/org.openbravo.retail.verystar/js/utils/verystarUtils.js ---

Issue History
Date Modified	Username	Field	Change
2019-03-18 13:18	malsasua	New Issue
2019-03-18 13:18	malsasua	Assigned To	=> Retail
2019-03-18 13:18	malsasua	Resolution time	=> 1554933600
2019-03-18 13:18	malsasua	Triggers an Emergency Pack	=> No
2019-03-18 13:30	malsasua	File Added: issueVeryStar_org.openbravo.retail.verystar.diff
2019-03-18 13:30	malsasua	File Added: issueVeryStar_org.openbravo.retail.selfcheckout.verystar.diff
2019-03-18 14:44	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2019-03-18 14:44	ranjith_qualiantech_com	Status	new => scheduled
2019-03-19 10:42	hgbot	Checkin
2019-03-19 10:42	hgbot	Note Added: 0110488
2019-03-19 10:42	hgbot	Checkin
2019-03-19 10:42	hgbot	Note Added: 0110489
2019-03-20 06:21	ranjith_qualiantech_com	Status	scheduled => resolved
2019-03-20 06:21	ranjith_qualiantech_com	Resolution	open => fixed
2019-03-28 14:10	marvintm	Review Assigned To	=> marvintm
2019-03-28 14:10	marvintm	Status	resolved => closed
2019-03-28 14:10	marvintm	Fixed in Version	=> RR19Q2
2019-04-03 09:31	ranjith_qualiantech_com	Relationship added	related to 0040510

Copyright © 2000 - 2009 MantisBT Group