Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040378
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] AEAT 303majorhave not tried2019-03-14 11:092019-03-20 10:25
ReporterOpentix-TestView Statuspublic 
Assigned ToOpentix-Test 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision4a503f8d6cc3
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Regression introduced in release
Summary

0040378: Tax Report 303 2019 - Delete line feed

DescriptionTax Report 303 2019 - Delete line feed
Steps To Reproduce1. Go to tax report launcher
2. Generate file. Period: february or 1T
3. Open file
4. Verify line feed
Proposed SolutionThe expected file format is a plain text file but there is a line feed (there must not be a line break)
TagsNo tags attached.
Attached Filesxlsx file icon DR303e19v10_10.xlsx [^] (298,226 bytes) 2019-03-18 09:15

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0110456)
psanjuan (manager)
2019-03-15 12:27

As workaround delete last line.
(0110506)
hgbot (developer)
2019-03-20 10:23

Repository: erp/pmods/org.openbravo.module.aeat303.es
Changeset: 4a503f8d6cc3a8e65767e0c40e3e383c22bd020c
Author: Iñaki Monferrer Altava <imonferrer <at> opentix.es>
Date: Mon Mar 18 16:04:29 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat303.es/rev/4a503f8d6cc3a8e65767e0c40e3e383c22bd020c [^]

Fixed bug 40378: Tax Report 303 2019 - Delete line feed.
Deleted line feed at the end of the file.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/aeat303/es/report/v2019/AEAT303Report2019.java
---
(0110507)
hgbot (developer)
2019-03-20 10:24

Repository: erp/pmods/org.openbravo.module.aeat303.es
Changeset: eeea1f7901a07339ea35b8a0b113cc632ad5642f
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Mar 20 10:22:23 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat303.es/rev/eeea1f7901a07339ea35b8a0b113cc632ad5642f [^]

Related to issue 40378: code review improvements

Extracted logic to a private method.
Set CLFR length in a static variable to make sure the length is always properly calculated.
Use setLength() to avoid conversions from/to String

---
M src/org/openbravo/module/aeat303/es/report/v2019/AEAT303Report2019.java
---
(0110508)
vmromanos (manager)
2019-03-20 10:25

Code review + testing OK.

Fixed in Tax Report: Modelo 303 (Spain) 1.8.400 or above

- Issue History
Date Modified Username Field Change
2019-03-14 11:09 Opentix-Test New Issue
2019-03-14 11:09 Opentix-Test Assigned To => Opentix-Test
2019-03-14 11:21 Opentix-Test Steps to Reproduce Updated View Revisions
2019-03-14 11:21 Opentix-Test Proposed Solution updated
2019-03-14 11:25 Opentix-Test Proposed Solution updated
2019-03-14 16:19 ivancace Issue Monitored: ivancace
2019-03-15 12:26 psanjuan Severity critical => major
2019-03-15 12:26 psanjuan Proposed Solution updated
2019-03-15 12:26 psanjuan Status new => scheduled
2019-03-15 12:27 psanjuan Note Added: 0110456
2019-03-15 12:40 psanjuan Type feature request => defect
2019-03-18 09:15 Opentix-Test File Added: DR303e19v10_10.xlsx
2019-03-20 10:23 hgbot Checkin
2019-03-20 10:23 hgbot Note Added: 0110506
2019-03-20 10:23 hgbot Status scheduled => resolved
2019-03-20 10:23 hgbot Resolution open => fixed
2019-03-20 10:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat303.es/rev/4a503f8d6cc3a8e65767e0c40e3e383c22bd020c [^]
2019-03-20 10:24 hgbot Checkin
2019-03-20 10:24 hgbot Note Added: 0110507
2019-03-20 10:25 vmromanos Review Assigned To => vmromanos
2019-03-20 10:25 vmromanos Note Added: 0110508
2019-03-20 10:25 vmromanos Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker