Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040352
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] StoreServermajorhave not tried2019-03-11 17:502019-03-27 15:34
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision33dd7bb9ac62
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040352: Only notify import entry manager of new entry when really needed, remove usage of import entry in multi-server

DescriptionThe code here [1] calls the import entry manager to process although many times there won't be a new import entry to process.

Also the current code still has old/deprecated behavior in that import entries are created. This should be removed.


[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l201 [^]
Steps To ReproduceInstall multi-server and synchronized transaction
Put a breakpoint in the code as above, see that it is called even if no import entry is created
Proposed SolutionOnly kick the import entry process if it is really needed, when an import entry got created.

Remove all creation of import entries
TagsPerformance
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0110371)
hgbot (developer)
2019-03-12 08:54

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 554c4dd35e97affbb18998edcdedb18b42c395d1
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 12 08:54:39 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/554c4dd35e97affbb18998edcdedb18b42c395d1 [^]

Fixes issue 40352: Only notify import entry manager of new entry when really needed
In the current approach there is no need to notify the import entry manager
as no new entries are created for processing. I checked all subclasses in the customer
instance also.

---
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0110446)
AugustoMauch (developer)
2019-03-14 17:56

Reopened, because it seems some subclass do create import entries.
(0110493)
hgbot (developer)
2019-03-19 16:52

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 33dd7bb9ac628dbddf976efd10e4ded79fa6eda9
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 19 16:52:51 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/33dd7bb9ac628dbddf976efd10e4ded79fa6eda9 [^]

Fixes issue 40352: Only notify import entry manager of new entry when really needed, remove usage of import entry in multi-server
Only use import entry archive to prevent double requests, remove creation of import entry and handle case import entry
data type not correctly set

---
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0110494)
hgbot (developer)
2019-03-19 17:27

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 097f647a0af2fb488efafd2b7f92ad88723acd58
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 19 17:26:58 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/097f647a0af2fb488efafd2b7f92ad88723acd58 [^]

Related to issue 40352: Only notify import entry manager of new entry when really needed, remove usage of import entry in multi-server
Remove deprecated api.

---
M src/org/openbravo/retail/posterminal/process/IsOrderCancelled.java
---
(0110496)
hgbot (developer)
2019-03-19 18:16

Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 5271596e468f0bc6a5cb718908e873ecaad0915a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 19 18:14:00 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/5271596e468f0bc6a5cb718908e873ecaad0915a [^]

Related to issue 40352: Only notify import entry manager of new entry when really needed, remove usage of import entry in multi-server
Remove deprecated api usage

---
M src/org/openbravo/retail/giftcards/AbstractSimpleGiftCardProcess.java
---
(0110497)
hgbot (developer)
2019-03-19 18:21

Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 2cdef2e80caebf04f2d62679a9dd16c07d3509d3
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 19 18:21:27 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/2cdef2e80caebf04f2d62679a9dd16c07d3509d3 [^]

Related to issue 40352: Only notify import entry manager of new entry when really needed, remove usage of import entry in multi-server
Remove deprecated api override

---
M src/org/openbravo/retail/giftcards/CancelGiftCard.java
M src/org/openbravo/retail/giftcards/CancelGiftCardTransaction.java
M src/org/openbravo/retail/giftcards/CloseGiftCard.java
M src/org/openbravo/retail/giftcards/ConsumeGiftCardAmount.java
M src/org/openbravo/retail/giftcards/ConsumeGiftCardLines.java
M src/org/openbravo/retail/giftcards/FindGiftCard.java
M src/org/openbravo/retail/giftcards/GiftCardCertificate.java
M src/org/openbravo/retail/giftcards/RevertGiftCardAmount.java
---
(0110498)
hgbot (developer)
2019-03-19 18:24

Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: ed27e916bb6500b4f5e133ff327e3c06d7e6d999
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 19 18:24:34 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/ed27e916bb6500b4f5e133ff327e3c06d7e6d999 [^]

Related to issue 40352: Only notify import entry manager of new entry when really needed, remove usage of import entry in multi-server
Remove override of deprecated api

---
M src/org/openbravo/retail/sessions/WebPOSCloseStore.java
---
(0110529)
aaroncalero (developer)
2019-03-21 09:37

Related Loyalty commit: https://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/752e9cdd59cc [^]
(0110696)
AugustoMauch (developer)
2019-03-27 15:34

Code reviewed and verified

- Issue History
Date Modified Username Field Change
2019-03-11 17:50 mtaal New Issue
2019-03-11 17:50 mtaal Assigned To => mtaal
2019-03-11 17:50 mtaal Triggers an Emergency Pack => No
2019-03-12 08:54 alostale Tag Attached: Performance
2019-03-12 08:54 hgbot Checkin
2019-03-12 08:54 hgbot Note Added: 0110371
2019-03-12 08:54 hgbot Status new => resolved
2019-03-12 08:54 hgbot Resolution open => fixed
2019-03-12 08:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/554c4dd35e97affbb18998edcdedb18b42c395d1 [^]
2019-03-12 08:54 alostale Issue Monitored: alostale
2019-03-12 09:08 mtaal Review Assigned To => AugustoMauch
2019-03-14 17:56 AugustoMauch Note Added: 0110446
2019-03-14 17:56 AugustoMauch Status resolved => new
2019-03-14 17:56 AugustoMauch Resolution fixed => open
2019-03-19 16:32 mtaal Summary Only notify import entry manager of new entry when really needed => Only notify import entry manager of new entry when really needed, remove usage of import entry in multi-server
2019-03-19 16:32 mtaal Description Updated View Revisions
2019-03-19 16:32 mtaal Proposed Solution updated
2019-03-19 16:52 hgbot Checkin
2019-03-19 16:52 hgbot Note Added: 0110493
2019-03-19 16:52 hgbot Status new => resolved
2019-03-19 16:52 hgbot Resolution open => fixed
2019-03-19 16:52 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/554c4dd35e97affbb18998edcdedb18b42c395d1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/33dd7bb9ac628dbddf976efd10e4ded79fa6eda9 [^]
2019-03-19 17:27 hgbot Checkin
2019-03-19 17:27 hgbot Note Added: 0110494
2019-03-19 18:16 hgbot Checkin
2019-03-19 18:16 hgbot Note Added: 0110496
2019-03-19 18:21 hgbot Checkin
2019-03-19 18:21 hgbot Note Added: 0110497
2019-03-19 18:24 hgbot Checkin
2019-03-19 18:24 hgbot Note Added: 0110498
2019-03-21 09:37 aaroncalero Note Added: 0110529
2019-03-27 15:34 AugustoMauch Note Added: 0110696
2019-03-27 15:34 AugustoMauch Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker