0040295: Responses from OB.RemoteCallManager calls are not handled if the Smartclient timeout is fired

Description

Responses from OB.RemoteCallManager calls are not handled if the Smartclient timeout is fired . This is a change in the behavior introduced with the following changeset[1].

Before that change the timeout error was not being properly handled causing the thrown of JS errors in the console. Despite this errors, the response was being handled by Smatclient.

Now the timeout error is being handled, showing the message in the UI. But seems that this causes the request response to be ignored when it finishes.

[1] https://code.openbravo.com/erp/devel/pi/rev/0b908a2c7f992827a230b06193ad7f8f9bd2ce9b#l1.37 [^]

Steps To Reproduce

Artificial test:

1) Open the [Sales Order] window
2) Create a new sales order with at least one line and book it
3) Open the Add Payment window
4) Using the dev tools console reduce the timeout to be able to simulate the timeout expiration: isc.RPCManager.defaultTimeout = 1000
5) Put a breakpoint in the AddPaymentActionHandler class
6) In the client the message information about the timeout expiration appears
7) Step over the breakpoint and finish the execution of the handler --> note that the response message from the action handler does not apper

Before the mentioned changeset, the behavior was different:

1) The timeout message was not appearing (the error was thrown in the console instead)
2) The process pop-up was closed
3) The message from the action handler was shown properly in the header

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0040253

closed

jarmendariz

Responses from OB.RemoteCallManager calls are not handled if the Smartclient timeout is fired

Notes
(0110131) hgbot (developer) 2019-02-28 18:04	Repository: erp/backports/3.0PR19Q1 Changeset: ed8211bf7fdbf669fd77100a7297f3d00155a68b Author: Javier Armendáriz <javier.armendariz <at> openbravo.com> Date: Thu Feb 28 10:53:54 2019 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR19Q1/rev/ed8211bf7fdbf669fd77100a7297f3d00155a68b [^] Fixed issue 40295: RemoteCallManager response not handled when timemout is fired. Removed result sanitizing in RPCManager. This makes timeout message appears but also marks the request as complete and the actual response is not processed when it arrives. --- M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js ---

(0110308) caristu (developer) 2019-03-08 10:47	Code reviewed + tested OK.

Issue History
Date Modified	Username	Field	Change
2019-02-28 17:10	jarmendariz	Type	defect => backport
2019-02-28 17:10	jarmendariz	Target Version	=> 3.0PR19Q1
2019-02-28 18:04	hgbot	Checkin
2019-02-28 18:04	hgbot	Note Added: 0110131
2019-02-28 18:04	hgbot	Status	scheduled => resolved
2019-02-28 18:04	hgbot	Resolution	open => fixed
2019-02-28 18:04	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR19Q1/rev/ed8211bf7fdbf669fd77100a7297f3d00155a68b [^]
2019-02-28 18:04	jarmendariz	Assigned To	jarmendariz => caristu
2019-02-28 18:05	jarmendariz	Assigned To	caristu => jarmendariz
2019-02-28 18:05	jarmendariz	Review Assigned To	=> caristu
2019-03-08 10:47	caristu	Note Added: 0110308
2019-03-08 10:47	caristu	Status	resolved => closed
2019-03-08 10:47	caristu	Fixed in Version	=> 3.0PR19Q1